Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 139303007: Deprecate the TextTrackCue constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase and revert incorrect test change Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/custom/V8TextTrackCueCustom.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 1
2 /* 2 /*
3 * Copyright (C) 2012 Google, Inc. All rights reserved. 3 * Copyright (C) 2012 Google, Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 670 matching lines...) Expand 10 before | Expand all | Expand 10 after
681 681
682 case CSSStyleSheetInsertRuleOptionalArg: 682 case CSSStyleSheetInsertRuleOptionalArg:
683 return "Calling CSSStyleSheet.insertRule() with one argument is deprecat ed. Please pass the index argument as well: insertRule(x, 0)."; 683 return "Calling CSSStyleSheet.insertRule() with one argument is deprecat ed. Please pass the index argument as well: insertRule(x, 0).";
684 684
685 case AttributeSpecified: 685 case AttributeSpecified:
686 return "Attr.specified is deprecated. Its value is always true."; 686 return "Attr.specified is deprecated. Its value is always true.";
687 687
688 case SVGElementGetPresentationAttribute: 688 case SVGElementGetPresentationAttribute:
689 return "CSSValue and SVGElement.getPresentationAttribute are deprecated. Please use getPropertyValue and parse the return value instead."; 689 return "CSSValue and SVGElement.getPresentationAttribute are deprecated. Please use getPropertyValue and parse the return value instead.";
690 690
691 case TextTrackCueConstructor:
692 return "The 'TextTrackCue' constructor is deprecated. Please use 'VTTCue ' instead.";
693
691 // Features that aren't deprecated don't have a deprecation message. 694 // Features that aren't deprecated don't have a deprecation message.
692 default: 695 default:
693 return String(); 696 return String();
694 } 697 }
695 } 698 }
696 699
697 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 700 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
698 { 701 {
699 ASSERT(feature >= firstCSSProperty); 702 ASSERT(feature >= firstCSSProperty);
700 ASSERT(feature <= lastCSSProperty); 703 ASSERT(feature <= lastCSSProperty);
(...skipping 28 matching lines...) Expand all
729 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 732 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
730 { 733 {
731 // FIXME: We may want to handle stylesheets that have multiple owners 734 // FIXME: We may want to handle stylesheets that have multiple owners
732 // http://crbug.com/242125 735 // http://crbug.com/242125
733 if (sheetContents && sheetContents->hasSingleOwnerNode()) 736 if (sheetContents && sheetContents->hasSingleOwnerNode())
734 return getFrom(sheetContents->singleOwnerDocument()); 737 return getFrom(sheetContents->singleOwnerDocument());
735 return 0; 738 return 0;
736 } 739 }
737 740
738 } // namespace WebCore 741 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/custom/V8TextTrackCueCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698