Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139273007: Web Animations: Remove legacy animations engine. (Closed)

Created:
6 years, 11 months ago by dstockwell
Modified:
6 years, 10 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, shans, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, Steve Block, dino_apple.com, alancutter (OOO until 2018), bemjb+rendering_chromium.org, dsinclair, Timothy Loh, dstockwell, dglazkov+blink, jchaffraix+rendering, Eric Willigers, rjwright, zoltan1, sof, darktears, leviw+renderwatch, blink-layers+watch_chromium.org, Mike Lawther (Google), Inactive
Visibility:
Public.

Description

Web Animations: Remove legacy animations engine. BUG=334225 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166881

Patch Set 1 #

Patch Set 2 : Remove more dead code. #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : Rebase. #

Patch Set 5 : Fixed rebase. #

Patch Set 6 : Fix build. #

Patch Set 7 : Clean up CSSPropertyAnimation #

Patch Set 8 : Fix TestExpectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -6365 lines) Patch
M LayoutTests/StaleTestExpectations View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 chunks +0 lines, -22 lines 0 comments Download
D LayoutTests/platform/android/virtual/legacy-animations-engine/transitions/opacity-transition-zindex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/legacy-animations-engine/animations/interpolation/line-height-interpolation-expected.txt View 1 chunk +0 lines, -82 lines 0 comments Download
D LayoutTests/platform/linux/virtual/legacy-animations-engine/animations/keyframe-multiple-timing-functions-transform-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/legacy-animations-engine/transitions/opacity-transform-transitions-inside-iframe-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/legacy-animations-engine/transitions/opacity-transform-transitions-inside-iframe-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac-lion/virtual/legacy-animations-engine/transitions/opacity-transform-transitions-inside-iframe-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/virtual/legacy-animations-engine/transitions/opacity-transform-transitions-inside-iframe-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac-retina/virtual/legacy-animations-engine/transitions/opacity-transform-transitions-inside-iframe-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac-snowleopard/virtual/legacy-animations-engine/transitions/opacity-transform-transitions-inside-iframe-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/legacy-animations-engine/animations/keyframe-multiple-timing-functions-transform-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/legacy-animations-engine/transitions/opacity-transform-transitions-inside-iframe-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/legacy-animations-engine/transitions/opacity-transition-zindex-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/legacy-animations-engine/transitions/opacity-transform-transitions-inside-iframe-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/win/virtual/legacy-animations-engine/animations/interpolation/line-height-interpolation-expected.txt View 1 chunk +0 lines, -82 lines 0 comments Download
D LayoutTests/platform/win/virtual/legacy-animations-engine/animations/keyframe-multiple-timing-functions-transform-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/legacy-animations-engine/transitions/opacity-transform-transitions-inside-iframe-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/virtual/legacy-animations-engine/transitions/opacity-transition-zindex-expected.png View Binary file 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/animation-direction-reverse-fill-mode-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/animation-none-keyword-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/display-change-does-not-terminate-animation-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/fill-mode-iteration-count-non-integer-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/background-image-interpolation-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/background-position-interpolation-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/background-size-interpolation-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/border-image-outset-interpolation-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/border-image-slice-interpolation-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/border-image-source-interpolation-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/border-image-width-interpolation-expected.txt View 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/border-radius-interpolation-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/border-spacing-interpolation-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/box-shadow-interpolation-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/calc-interpolation-expected.txt View 1 chunk +0 lines, -29 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/clip-interpolation-expected.txt View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/filter-interpolation-expected.txt View 1 chunk +0 lines, -96 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/flex-interpolation-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/line-height-interpolation-expected.txt View 1 chunk +0 lines, -82 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/list-style-image-interpolation-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/max-height-interpolation-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/max-width-interpolation-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/min-height-interpolation-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/min-width-interpolation-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/object-position-interpolation-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/orphans-interpolation-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/padding-interpolation-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/perspective-origin-interpolation-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/shape-inside-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/shape-outside-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/svg-fill-interpolation-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/svg-fill-opacity-interpolation-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/svg-flood-opacity-interpolation-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/svg-stop-opacity-interpolation-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/svg-stroke-dasharray-interpolation-expected.txt View 1 chunk +0 lines, -75 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/svg-stroke-interpolation-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/svg-stroke-miterlimit-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/svg-stroke-opacity-interpolation-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/svg-stroke-width-interpolation-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/text-decoration-color-interpolation-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/transform-interpolation-expected.txt View 1 chunk +0 lines, -289 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/transform-origin-interpolation-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/visibility-interpolation-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/webkit-background-size-interpolation-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/webkit-clip-path-interpolation-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/webkit-column-gap-interpolation-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/webkit-column-width-interpolation-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/webkit-mask-box-image-outset-interpolation-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/webkit-mask-box-image-slice-interpolation-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/webkit-mask-box-image-source-interpolation-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/webkit-mask-box-image-width-interpolation-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/webkit-mask-image-interpolation-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/webkit-mask-position-interpolation-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/webkit-mask-size-interpolation-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/widows-interpolation-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/width-interpolation-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/interpolation/zoom-iterpolation-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/missing-from-to-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/missing-from-to-transforms-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/timing-model-expected.txt View 1 chunk +0 lines, -143 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/animations/unsigned-underflow-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/transitions/flex-transitions-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/transitions/negative-delay-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/transitions/svg-transitions-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/virtual/legacy-animations-engine/transitions/zero-duration-with-non-zero-delay-start-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/animation/ActiveAnimations.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 2 chunks +0 lines, -12 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/RenderTreeBuilder.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Frame.h View 1 2 4 chunks +0 lines, -8 lines 0 comments Download
M Source/core/frame/Frame.cpp View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
D Source/core/frame/animation/AnimationBase.h View 1 chunk +0 lines, -228 lines 0 comments Download
D Source/core/frame/animation/AnimationBase.cpp View 1 chunk +0 lines, -585 lines 0 comments Download
D Source/core/frame/animation/AnimationController.h View 1 chunk +0 lines, -104 lines 0 comments Download
D Source/core/frame/animation/AnimationController.cpp View 1 chunk +0 lines, -542 lines 0 comments Download
D Source/core/frame/animation/AnimationControllerPrivate.h View 1 chunk +0 lines, -140 lines 0 comments Download
D Source/core/frame/animation/CSSPropertyAnimation.h View 1 2 1 chunk +1 line, -7 lines 0 comments Download
M Source/core/frame/animation/CSSPropertyAnimation.cpp View 1 2 3 4 5 6 17 chunks +160 lines, -747 lines 0 comments Download
D Source/core/frame/animation/CompositeAnimation.h View 1 chunk +0 lines, -96 lines 0 comments Download
D Source/core/frame/animation/CompositeAnimation.cpp View 1 chunk +0 lines, -510 lines 0 comments Download
D Source/core/frame/animation/ImplicitAnimation.h View 1 chunk +0 lines, -98 lines 0 comments Download
D Source/core/frame/animation/ImplicitAnimation.cpp View 1 chunk +0 lines, -283 lines 0 comments Download
D Source/core/frame/animation/KeyframeAnimation.h View 1 chunk +0 lines, -102 lines 0 comments Download
D Source/core/frame/animation/KeyframeAnimation.cpp View 1 chunk +0 lines, -455 lines 0 comments Download
M Source/core/rendering/CompositedLayerMapping.h View 1 2 3 3 chunks +0 lines, -12 lines 0 comments Download
M Source/core/rendering/CompositedLayerMapping.cpp View 1 2 3 5 chunks +2 lines, -114 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 1 chunk +0 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 2 3 4 chunks +2 lines, -16 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.cpp View 1 2 3 4 4 chunks +0 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderObject.h View 1 2 3 chunks +0 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 3 4 chunks +0 lines, -16 lines 0 comments Download
D Source/core/rendering/animation/WebAnimationProvider.h View 1 1 chunk +0 lines, -76 lines 0 comments Download
D Source/core/rendering/animation/WebAnimationProvider.cpp View 1 1 chunk +0 lines, -214 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 3 3 chunks +1 line, -4 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dstockwell
6 years, 10 months ago (2014-01-31 03:15:24 UTC) #1
Timothy Loh
rslgtm++ I guess the RuntimeEnabledFeatures::webAnimationsCSSEnabled() will be removed in a later patch? https://codereview.chromium.org/139273007/diff/110001/LayoutTests/TestExpectations File LayoutTests/TestExpectations ...
6 years, 10 months ago (2014-01-31 03:22:03 UTC) #2
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 10 months ago (2014-02-10 21:49:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/139273007/230001
6 years, 10 months ago (2014-02-10 21:49:45 UTC) #4
dstockwell
The CQ bit was checked by dstockwell@chromium.org
6 years, 10 months ago (2014-02-10 23:10:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/139273007/310001
6 years, 10 months ago (2014-02-10 23:10:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/139273007/310001
6 years, 10 months ago (2014-02-10 23:43:31 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 00:42:24 UTC) #8
Message was sent while issue was closed. 
Change committed as 166881

Powered by Google App Engine
This is Rietveld 408576698