[Autofill] Add metric for profile action on form submitted

[Autofill] Add metric for profile action on form submitted

It will log whether an existing profile was used, was edited or a new profile was created.

BUG=539944
Committed: https://crrev.com/3c7d234ede220c9d154e760f55ce52645205b88a
Cr-Commit-Position: refs/heads/master@{#354257}

[sebsg, 2015-10-06 20:36:02]

Patchset #1 (id:1) has been deleted

[sebsg, 2015-10-06 20:37:23]

sebsg@chromium.org changed reviewers:
+ mathp@chromium.org

[sebsg, 2015-10-06 20:52:22]

sebsg@chromium.org changed reviewers:
+ estade@chromium.org, rkaplow@chromium.org

[sebsg, 2015-10-06 20:52:23]

rkaplow@chromium.org: Please review changes in
tools/metrics/histograms/histograms.xml

estade@chromium.org: Please review changes in components/autofill/core/browser/*

[Evan Stade, 2015-10-06 21:01:01]

https://codereview.chromium.org/1392623002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_profile.cc (right):

https://codereview.chromium.org/1392623002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_profile.cc:556:
OverwriteName(profile.name_, app_locale);
this doesn't count?

[rkaplow, 2015-10-07 15:04:56]

https://codereview.chromium.org/1392623002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_metrics.cc (right):

https://codereview.chromium.org/1392623002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics.cc:638: NEW_PROFILE_CREATED);
this should be the max value enum entry

https://codereview.chromium.org/1392623002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_metrics.h (right):

https://codereview.chromium.org/1392623002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics.h:28: NEW_PROFILE_CREATED,
should have something like
AUTOFILL_PROFILE_ACTION_ENUM_SIZE as the last entry

[sebsg, 2015-10-08 14:55:06]

Could you take another look? Thanks.

https://codereview.chromium.org/1392623002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_metrics.cc (right):

https://codereview.chromium.org/1392623002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics.cc:638: NEW_PROFILE_CREATED);
On 2015/10/07 15:04:56, rkaplow wrote:
> this should be the max value enum entry

Done.

https://codereview.chromium.org/1392623002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_metrics.h (right):

https://codereview.chromium.org/1392623002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_metrics.h:28: NEW_PROFILE_CREATED,
On 2015/10/07 15:04:56, rkaplow wrote:
> should have something like
> AUTOFILL_PROFILE_ACTION_ENUM_SIZE as the last entry

Done.

https://codereview.chromium.org/1392623002/diff/20001/components/autofill/cor...
File components/autofill/core/browser/autofill_profile.cc (right):

https://codereview.chromium.org/1392623002/diff/20001/components/autofill/cor...
components/autofill/core/browser/autofill_profile.cc:556:
OverwriteName(profile.name_, app_locale);
On 2015/10/06 21:01:01, Evan Stade wrote:
> this doesn't count?

Done.

[rkaplow, 2015-10-08 14:58:04]

lgtm

histograms lgtm

[sebsg, 2015-10-14 13:42:22]

Evan could you take another look? Thanks!

[Evan Stade, 2015-10-14 20:42:01]

lgtm

https://codereview.chromium.org/1392623002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/autofill_profile.cc (right):

https://codereview.chromium.org/1392623002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_profile.cc:561: did_overwrite = true;
nit: did_overwrite = OverwriteName() || did_overwrite;

[sebsg, 2015-10-15 01:31:22]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2015-10-15 01:31:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1392623002/#ps60001
(title: "Nit")

[commit-bot: I haz the power, 2015-10-15 01:33:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1392623002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1392623002/60001

[commit-bot: I haz the power, 2015-10-15 01:35:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-15 01:35:49]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sebsg, 2015-10-15 12:16:38]

The CQ bit was checked by sebsg@chromium.org

[sebsg, 2015-10-15 12:16:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
rkaplow@chromium.org, estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1392623002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-10-15 12:16:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1392623002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1392623002/80001

[commit-bot: I haz the power, 2015-10-15 13:45:37]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-10-15 13:46:32]

Patchset 4 (id:??) landed as
https://crrev.com/3c7d234ede220c9d154e760f55ce52645205b88a
Cr-Commit-Position: refs/heads/master@{#354257}

[sebsg, 2015-10-21 17:35:26]

https://codereview.chromium.org/1392623002/diff/40001/components/autofill/cor...
File components/autofill/core/browser/autofill_profile.cc (right):

https://codereview.chromium.org/1392623002/diff/40001/components/autofill/cor...
components/autofill/core/browser/autofill_profile.cc:561: did_overwrite = true;
On 2015/10/14 20:42:01, Evan Stade wrote:
> nit: did_overwrite = OverwriteName() || did_overwrite;

Done.