Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: components/autofill/core/browser/autofill_profile.h

Issue 1392623002: [Autofill] Add metric for profile action on form submitted (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_profile.h
diff --git a/components/autofill/core/browser/autofill_profile.h b/components/autofill/core/browser/autofill_profile.h
index d52f228c0d52f7bbb21196fcf9935a523877d287..bfe97b0a3e28dd3269e8d322daeef80029c52857 100644
--- a/components/autofill/core/browser/autofill_profile.h
+++ b/components/autofill/core/browser/autofill_profile.h
@@ -114,8 +114,9 @@ class AutofillProfile : public AutofillDataModel {
const std::string& app_locale,
const ServerFieldTypeSet& types) const;
- // Overwrites the field data in |profile| with this Profile.
- void OverwriteWith(const AutofillProfile& profile,
+ // Overwrites the field data in |profile| with this Profile. Returns |true| if
+ // at least one field was overwritten.
+ bool OverwriteWith(const AutofillProfile& profile,
const std::string& app_locale);
// Saves info from |profile| into |this|, provided |this| and |profile| do not
@@ -223,7 +224,8 @@ class AutofillProfile : public AutofillDataModel {
// If |name| has the same full name representation as |name_|,
// this will keep the one that has more information (i.e.
// is not reconstructible via a heuristic parse of the full name string).
- void OverwriteName(const NameInfo& name, const std::string& app_locale);
+ // Returns |true| is |name_| was overwritten.
+ bool OverwriteName(const NameInfo& name, const std::string& app_locale);
// Same as operator==, but ignores differences in GUID.
bool EqualsSansGuid(const AutofillProfile& profile) const;
« no previous file with comments | « components/autofill/core/browser/autofill_metrics_unittest.cc ('k') | components/autofill/core/browser/autofill_profile.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698