[Autofill] Add metric for profile action on form submitted

components/autofill/core/browser/autofill_metrics_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_metrics.h"
 
 #include <vector>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_service.h"
@@ skipping 3055 matching lines @@
         "Autofill.FillDuration.FromLoad.WithoutAutofill", 12, 1);
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromInteraction.WithAutofill", 0);
     histogram_tester.ExpectTotalCount(
         "Autofill.FillDuration.FromInteraction.WithoutAutofill", 0);
 
     autofill_manager_->Reset();
   }
 }
 
-// Verify that we correctly log metrics for profile creation on form submission.
-TEST_F(AutofillMetricsTest, AutomaticProfileCreation) {
+// Verify that we correctly log metrics for profile action on form submission.
+TEST_F(AutofillMetricsTest, ProfileActionOnFormSubmitted) {
   base::HistogramTester histogram_tester;
 
   // Load a fillable form.
   FormData form;
   form.name = ASCIIToUTF16("TestForm");
   form.origin = GURL("http://example.com/form.html");
   form.action = GURL("http://example.com/submit.html");
 
   // Create the form's fields.
   FormFieldData field;
   test::CreateTestFormField("Name", "name", "", "text", &field);
   form.fields.push_back(field);
   test::CreateTestFormField("Email", "email", "", "text", &field);
   form.fields.push_back(field);
   test::CreateTestFormField("Phone", "phone", "", "text", &field);
   form.fields.push_back(field);
   test::CreateTestFormField("Address", "address", "", "text", &field);
   form.fields.push_back(field);
   test::CreateTestFormField("City", "city", "", "text", &field);
   form.fields.push_back(field);
   test::CreateTestFormField("Country", "country", "", "text", &field);
   form.fields.push_back(field);
   test::CreateTestFormField("State", "state", "", "text", &field);
   form.fields.push_back(field);
   test::CreateTestFormField("Zip", "zip", "", "text", &field);
   form.fields.push_back(field);
+  test::CreateTestFormField("Organization", "organization", "", "text", &field);
+  form.fields.push_back(field);
 
   std::vector<FormData> forms(1, form);
 
   // Fill second form.
   FormData second_form = form;
   std::vector<FormData> second_forms(1, second_form);
 
   // Fill a third form.
   FormData third_form = form;
   std::vector<FormData> third_forms(1, third_form);
 
+  // Fill a fourth form.
+  FormData fourth_form = form;
+  std::vector<FormData> fourth_forms(1, fourth_form);
+
   // Fill the field values for the first form submission.
   form.fields[0].value = ASCIIToUTF16("Albert Canuck");
   form.fields[1].value = ASCIIToUTF16("can@gmail.com");
   form.fields[2].value = ASCIIToUTF16("12345678901");
   form.fields[3].value = ASCIIToUTF16("1234 McGill street.");
   form.fields[4].value = ASCIIToUTF16("Montreal");
   form.fields[5].value = ASCIIToUTF16("Canada");
   form.fields[6].value = ASCIIToUTF16("Quebec");
   form.fields[7].value = ASCIIToUTF16("A1A 1A1");
 
   // Fill the field values for the second form submission (same as first form).
   second_form.fields = form.fields;
 
   // Fill the field values for the third form submission.
   third_form.fields[0].value = ASCIIToUTF16("Jean-Paul Canuck");
   third_form.fields[1].value = ASCIIToUTF16("can2@gmail.com");
-  third_form.fields[2].value = ASCIIToUTF16("12345678901");
+  third_form.fields[2].value = ASCIIToUTF16("");
   third_form.fields[3].value = ASCIIToUTF16("1234 McGill street.");
   third_form.fields[4].value = ASCIIToUTF16("Montreal");
   third_form.fields[5].value = ASCIIToUTF16("Canada");
   third_form.fields[6].value = ASCIIToUTF16("Quebec");
   third_form.fields[7].value = ASCIIToUTF16("A1A 1A1");
 
-  // Expect to log true for the metric since a new profile is submitted.
+  // Fill the field values for the fourth form submission (same as third form
+  // plus phone info).
+  fourth_form.fields = third_form.fields;
+  fourth_form.fields[2].value = ASCIIToUTF16("12345678901");
+
+  // Expect to log NEW_PROFILE_CREATED for the metric since a new profile is
+  // submitted.
   autofill_manager_->OnFormsSeen(forms, TimeTicks::FromInternalValue(1));
   autofill_manager_->SubmitForm(form, TimeTicks::FromInternalValue(17));
-  histogram_tester.ExpectBucketCount("Autofill.AutomaticProfileCreation",
-                                     true, 1);
-  histogram_tester.ExpectBucketCount("Autofill.AutomaticProfileCreation",
-                                     false, 0);
+  histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
+                                     AutofillMetrics::NEW_PROFILE_CREATED, 1);
+  histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
+                                     AutofillMetrics::EXISTING_PROFILE_USED, 0);
+  histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
+                                     AutofillMetrics::EXISTING_PROFILE_UPDATED,
+                                     0);
 
-  // Expect to log false for the metric since the same profile is submitted.
+  // Expect to log EXISTING_PROFILE_USED for the metric since the same profile
+  // is submitted.
   autofill_manager_->OnFormsSeen(second_forms, TimeTicks::FromInternalValue(1));
   autofill_manager_->SubmitForm(second_form, TimeTicks::FromInternalValue(17));
-  histogram_tester.ExpectBucketCount("Autofill.AutomaticProfileCreation",
-                                     true, 1);
-  histogram_tester.ExpectBucketCount("Autofill.AutomaticProfileCreation",
-                                     false, 1);
+  histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
+                                     AutofillMetrics::NEW_PROFILE_CREATED, 1);
+  histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
+                                     AutofillMetrics::EXISTING_PROFILE_USED, 1);
+  histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
+                                     AutofillMetrics::EXISTING_PROFILE_UPDATED,
+                                     0);
 
-  // Expect to log true for the metric since a new profile is submitted.
+  // Expect to log NEW_PROFILE_CREATED for the metric since a new profile is
+  // submitted.
   autofill_manager_->OnFormsSeen(third_forms, TimeTicks::FromInternalValue(1));
   autofill_manager_->SubmitForm(third_form, TimeTicks::FromInternalValue(17));
-  histogram_tester.ExpectBucketCount("Autofill.AutomaticProfileCreation",
-                                     true, 2);
-  histogram_tester.ExpectBucketCount("Autofill.AutomaticProfileCreation",
-                                     false, 1);
+  histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
+                                     AutofillMetrics::NEW_PROFILE_CREATED, 2);
+  histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
+                                     AutofillMetrics::EXISTING_PROFILE_USED, 1);
+  histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
+                                     AutofillMetrics::EXISTING_PROFILE_UPDATED,
+                                     0);
+
+  // Expect to log EXISTING_PROFILE_UPDATED for the metric since the profile was
+  // updated.
+  autofill_manager_->OnFormsSeen(fourth_forms, TimeTicks::FromInternalValue(1));
+  autofill_manager_->SubmitForm(fourth_form, TimeTicks::FromInternalValue(17));
+  histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
+                                     AutofillMetrics::NEW_PROFILE_CREATED, 2);
+  histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
+                                     AutofillMetrics::EXISTING_PROFILE_USED, 1);
+  histogram_tester.ExpectBucketCount("Autofill.ProfileActionOnFormSubmitted",
+                                     AutofillMetrics::EXISTING_PROFILE_UPDATED,
+                                     1);
 }
 
 // Test class that shares setup code for testing ParseQueryResponse.
 class AutofillMetricsParseQueryResponseTest : public testing::Test {
  public:
   void SetUp() override {
     FormData form;
     form.origin = GURL("http://foo.com");
     FormFieldData field;
     field.form_control_type = "text";
@@ skipping 122 matching lines @@
   EXPECT_THAT(
       histogram_tester.GetAllSamples("Autofill.ServerResponseHasDataForForm"),
       ElementsAre(Bucket(true, 2)));
 
   // No RAPPOR metrics are logged in the case there is at least some server data
   // available for all forms.
   EXPECT_EQ(0, rappor_service_.GetReportsCount());
 }
 
 }  // namespace autofill