Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139173004: [#3] Pass gfx structs by const ref (gfx::SizeF) (Closed)

Created:
6 years, 11 months ago by r.kasibhatla
Modified:
6 years, 11 months ago
Reviewers:
danakj, bulach, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[#3] Pass gfx structs by const ref (gfx::SizeF) Avoid unneccessary copy of structures gfx::SizeF by passing them by const ref rather than value. Any struct of size > 4 bytes should be passed by const ref. Passing by ref for these structs is faster than passing by value, especially when invoking function has multiple parameters. Pass by value creates unneccessary overhead which should be avoided. BUG=159273 R=danakj, enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245297

Patch Set 1 #

Patch Set 2 : Rebase to ToT and fixed build error for Android platform! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M cc/base/math_util.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/base/math_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/input/layer_scroll_offset_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/input/page_scale_animation.h View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/input/page_scale_animation.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/output/render_surface_filters.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/render_surface_filters.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/quads/yuv_video_draw_quad.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/yuv_video_draw_quad.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/in_process/synchronous_compositor_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
r.kasibhatla
PTAL.
6 years, 11 months ago (2014-01-15 05:52:43 UTC) #1
danakj
LGTM
6 years, 11 months ago (2014-01-15 17:43:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/139173004/1
6 years, 11 months ago (2014-01-16 04:35:06 UTC) #3
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=139899
6 years, 11 months ago (2014-01-16 05:24:05 UTC) #4
r.kasibhatla
+ bulach for content/.../android/... files Fixed the build error for android platform. PTAL.
6 years, 11 months ago (2014-01-16 09:28:17 UTC) #5
bulach
lgtm for content/.../android/..., thanks!
6 years, 11 months ago (2014-01-16 10:59:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/139173004/350001
6 years, 11 months ago (2014-01-16 11:39:19 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247254
6 years, 11 months ago (2014-01-16 13:03:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/139173004/350001
6 years, 11 months ago (2014-01-16 13:12:53 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 19:59:33 UTC) #10
Message was sent while issue was closed. 
Change committed as 245297

Powered by Google App Engine
This is Rietveld 408576698