cc/layers/layer_impl_unittest.cc - Issue 139173004: [#3] Pass gfx structs by const ref (gfx::SizeF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer_impl_unittest.cc

Issue 139173004: [#3] Pass gfx structs by const ref (gfx::SizeF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT and fixed build error for Android platform! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/layers/layer_impl_unittest.cc

diff --git a/cc/layers/layer_impl_unittest.cc b/cc/layers/layer_impl_unittest.cc

index 9d90c04928e70527b32e3b3e4b328874106cd638..ecedaec74a150c1be553094a9e8d7ebffe83e46e 100644

--- a/cc/layers/layer_impl_unittest.cc

+++ b/cc/layers/layer_impl_unittest.cc

@@ -402,7 +402,7 @@ class ScrollDelegateIgnore : public LayerScrollOffsetDelegate {

}

virtual void SetTotalPageScaleFactor(float page_scale_factor) OVERRIDE {}

- virtual void SetScrollableSize(gfx::SizeF scrollable_size) OVERRIDE {}

+ virtual void SetScrollableSize(const gfx::SizeF& scrollable_size) OVERRIDE {}

private:

gfx::Vector2dF fixed_offset_;

@@ -454,7 +454,7 @@ class ScrollDelegateAccept : public LayerScrollOffsetDelegate {

}

virtual bool IsExternalFlingActive() const OVERRIDE { return false; }

virtual void SetTotalPageScaleFactor(float page_scale_factor) OVERRIDE {}

- virtual void SetScrollableSize(gfx::SizeF scrollable_size) OVERRIDE {}

+ virtual void SetScrollableSize(const gfx::SizeF& scrollable_size) OVERRIDE {}

private:

gfx::Vector2dF current_offset_;

« no previous file with comments | « cc/input/page_scale_animation.cc ('k') | cc/output/render_surface_filters.h » ('j') | no next file with comments »