cc/input/page_scale_animation.h - Issue 139173004: [#3] Pass gfx structs by const ref (gfx::SizeF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/input/page_scale_animation.h

Issue 139173004: [#3] Pass gfx structs by const ref (gfx::SizeF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT and fixed build error for Android platform! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/input/page_scale_animation.h

diff --git a/cc/input/page_scale_animation.h b/cc/input/page_scale_animation.h

index 4c30cdcbc523e0e5cb740ab43448aa50de5d0ca9..f2e315d0325fbdc1aa22d4e78cdafaf0eacb9553 100644

--- a/cc/input/page_scale_animation.h

+++ b/cc/input/page_scale_animation.h

@@ -27,8 +27,8 @@ class PageScaleAnimation {

static scoped_ptr<PageScaleAnimation> Create(

gfx::Vector2dF start_scroll_offset,

float start_page_scale_factor,

- gfx::SizeF viewport_size,

- gfx::SizeF root_layer_size,

+ const gfx::SizeF& viewport_size,

+ const gfx::SizeF& root_layer_size,

scoped_ptr<TimingFunction> timing_function);

~PageScaleAnimation();

@@ -71,8 +71,8 @@ class PageScaleAnimation {

protected:

PageScaleAnimation(gfx::Vector2dF start_scroll_offset,