content/browser/android/in_process/synchronous_compositor_impl.h - Issue 139173004: [#3] Pass gfx structs by const ref (gfx::SizeF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/in_process/synchronous_compositor_impl.h

Issue 139173004: [#3] Pass gfx structs by const ref (gfx::SizeF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to ToT and fixed build error for Android platform! Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/in_process/synchronous_compositor_impl.h

diff --git a/content/browser/android/in_process/synchronous_compositor_impl.h b/content/browser/android/in_process/synchronous_compositor_impl.h

index f23d920a55505def27264e4953659443c1476c1b..a8eaba5379d232e225a0f602b6e0da820579bb7e 100644

--- a/content/browser/android/in_process/synchronous_compositor_impl.h

+++ b/content/browser/android/in_process/synchronous_compositor_impl.h

@@ -78,7 +78,7 @@ class SynchronousCompositorImpl

virtual gfx::Vector2dF GetTotalScrollOffset() OVERRIDE;

virtual bool IsExternalFlingActive() const OVERRIDE;

virtual void SetTotalPageScaleFactor(float page_scale_factor) OVERRIDE;

- virtual void SetScrollableSize(gfx::SizeF scrollable_size) OVERRIDE;

+ virtual void SetScrollableSize(const gfx::SizeF& scrollable_size) OVERRIDE;

void SetInputHandler(cc::InputHandler* input_handler);

void DidOverscroll(const cc::DidOverscrollParams& params);