Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1390163003: Cleanup of some old TODOs (Closed)

Created:
5 years, 2 months ago by jdduke (slow)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jdduke+watch_chromium.org, jam, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup of some old TODOs Remove some outdated or otherwise unnecessary TODOs, mostly related to input handling. BUG=NONE Committed: https://crrev.com/d455be75dd37d9d744130eaf95cd25c0586d6b18 Cr-Commit-Position: refs/heads/master@{#354167}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -19 lines) Patch
M chrome/browser/android/compositor/tab_content_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/android/content_startup_flags.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_perftest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/touch_selection/touch_selection_controller.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Issue 1405613002 Patch 1

Messages

Total messages: 10 (3 generated)
jdduke (slow)
tdresser@: PTAL, thanks.
5 years, 2 months ago (2015-10-12 16:23:50 UTC) #2
tdresser
LGTM
5 years, 2 months ago (2015-10-13 12:24:14 UTC) #3
jdduke (slow)
+dtrainor for chrome/browser/android
5 years, 2 months ago (2015-10-13 16:14:35 UTC) #5
David Trainor- moved to gerrit
chrome/browser/android lgtm.
5 years, 2 months ago (2015-10-14 22:59:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1390163003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1390163003/1
5 years, 2 months ago (2015-10-14 23:01:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-15 00:27:34 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 00:29:07 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d455be75dd37d9d744130eaf95cd25c0586d6b18
Cr-Commit-Position: refs/heads/master@{#354167}

Powered by Google App Engine
This is Rietveld 408576698