content/browser/android/content_startup_flags.cc - Issue 1390163003: Cleanup of some old TODOs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_startup_flags.cc

Issue 1390163003: Cleanup of some old TODOs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/content_startup_flags.cc

diff --git a/content/browser/android/content_startup_flags.cc b/content/browser/android/content_startup_flags.cc

index 2f0c632c85ece81a9606cab00dc3a2329f23496b..9821566fdd57193af7d8a84b44afae562e7f4d34 100644

--- a/content/browser/android/content_startup_flags.cc

+++ b/content/browser/android/content_startup_flags.cc

@@ -62,9 +62,8 @@ void SetContentCommandLineFlags(bool single_process,

parsed_command_line->AppendSwitch(switches::kEnableOverlayScrollbar);

parsed_command_line->AppendSwitch(switches::kValidateInputEventStream);

- // TODO(jdduke): Use the proper SDK version when available, crbug.com/466749.

- if (base::android::BuildInfo::GetInstance()->sdk_int() >

- base::android::SDK_VERSION_LOLLIPOP_MR1) {

+ if (base::android::BuildInfo::GetInstance()->sdk_int() >=

+ base::android::SDK_VERSION_MARSHMALLOW) {

parsed_command_line->AppendSwitch(switches::kEnableLongpressDragSelection);

parsed_command_line->AppendSwitchASCII(

switches::kTouchTextSelectionStrategy, "direction");