content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 1390163003: Cleanup of some old TODOs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 1390163003: Cleanup of some old TODOs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/input_router_impl_perftest.cc ('k') | content/renderer/input/input_handler_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index f3bd7259805dd3b53aa13dab667da64e6df83851..69d11cf978e8029adf93e805b3e2ad632d3cddc1 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -2636,7 +2636,6 @@ public class ContentViewCore implements

private boolean showPastePopup(int x, int y) {

if (!mHasInsertion || !canPaste()) return false;

- // TODO(jdduke): Factor out all selection/paste-related logic from ContentViewCore.

final float contentOffsetYPix = mRenderCoordinates.getContentOffsetYPix();

getPastePopup().show(x, (int) (y + contentOffsetYPix));

return true;

« no previous file with comments | « content/browser/renderer_host/input/input_router_impl_perftest.cc ('k') | content/renderer/input/input_handler_proxy.cc » ('j') | no next file with comments »