Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1389333003: Do not keep InvalidationSets on the Oilpan heap. (Closed)

Created:
5 years, 2 months ago by sof
Modified:
5 years, 2 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, devtools-reviews_chromium.org, caseq+blink_chromium.org, blink-reviews-style_chromium.org, pfeldman+blink_chromium.org, blink-reviews-css, sof, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not keep InvalidationSets on the Oilpan heap. An InvalidationSet keeps sets of names/strings and tend to have lifetimes that track those of RuleFeatureSets and not be shared. Hence it doesn't meet the bar for being on the Oilpan heap; for workloads where invalidations happen frequently, having them on the heap just causes unnecessary follow-on work in having to sweep out at some later GC. Trivially tidy up StyleResolver construction as part of this CL also. R=haraken BUG= Committed: https://crrev.com/dfa5b5b187a2ced692253672b963a3acb790eb24 Cr-Commit-Position: refs/heads/master@{#352829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -61 lines) Patch
M third_party/WebKit/Source/core/css/RuleFeature.h View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/InvalidationSet.h View 4 chunks +11 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp View 2 chunks +8 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/InvalidationSetTest.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look.
5 years, 2 months ago (2015-10-07 12:42:14 UTC) #2
haraken
LGTM
5 years, 2 months ago (2015-10-07 13:02:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389333003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389333003/1
5 years, 2 months ago (2015-10-07 13:20:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 14:23:03 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 14:23:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfa5b5b187a2ced692253672b963a3acb790eb24
Cr-Commit-Position: refs/heads/master@{#352829}

Powered by Google App Engine
This is Rietveld 408576698