Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.h

Issue 1389333003: Do not keep InvalidationSets on the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.h
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.h b/third_party/WebKit/Source/core/css/resolver/StyleResolver.h
index 95bfd33aaee91c22c38ecb8b779b2c580cdae04c..768cc3658e7bb6e8bcfc6649682d014ebd95c85a 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.h
+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.h
@@ -82,8 +82,11 @@ using ActiveInterpolationsMap = HashMap<PropertyHandle, Vector<RefPtr<Interpolat
class CORE_EXPORT StyleResolver final : public NoBaseWillBeGarbageCollectedFinalized<StyleResolver> {
WTF_MAKE_NONCOPYABLE(StyleResolver); WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(StyleResolver);
public:
- explicit StyleResolver(Document&);
- virtual ~StyleResolver();
+ static PassOwnPtrWillBeRawPtr<StyleResolver> create(Document& document)
+ {
+ return adoptPtrWillBeNoop(new StyleResolver(document));
+ }
+ ~StyleResolver();
// FIXME: StyleResolver should not be keeping tree-walk state.
// These should move to some global tree-walk state, or should be contained in a
@@ -185,6 +188,8 @@ public:
void addTreeBoundaryCrossingScope(ContainerNode& scope);
private:
+ explicit StyleResolver(Document&);
+
PassRefPtr<ComputedStyle> initialStyleForElement();
void initWatchedSelectorRules();

Powered by Google App Engine
This is Rietveld 408576698