Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: third_party/WebKit/Source/core/inspector/InspectorTraceEvents.cpp

Issue 1389333003: Do not keep InvalidationSets on the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/inspector/InspectorTraceEvents.h" 6 #include "core/inspector/InspectorTraceEvents.h"
7 7
8 #include "bindings/core/v8/ScriptCallStackFactory.h" 8 #include "bindings/core/v8/ScriptCallStackFactory.h"
9 #include "bindings/core/v8/ScriptSourceCode.h" 9 #include "bindings/core/v8/ScriptSourceCode.h"
10 #include "core/animation/Animation.h" 10 #include "core/animation/Animation.h"
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorStyleInvalidatorInvali dateEvent::selectorPart(Element& element, const char* reason, const Invalidation Set& invalidationSet, const String& selectorPart) 240 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorStyleInvalidatorInvali dateEvent::selectorPart(Element& element, const char* reason, const Invalidation Set& invalidationSet, const String& selectorPart)
241 { 241 {
242 RefPtr<TracedValue> value = fillCommonPart(element, reason); 242 RefPtr<TracedValue> value = fillCommonPart(element, reason);
243 value->beginArray("invalidationList"); 243 value->beginArray("invalidationList");
244 invalidationSet.toTracedValue(value.get()); 244 invalidationSet.toTracedValue(value.get());
245 value->endArray(); 245 value->endArray();
246 value->setString("selectorPart", selectorPart); 246 value->setString("selectorPart", selectorPart);
247 return value.release(); 247 return value.release();
248 } 248 }
249 249
250 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorStyleInvalidatorInvali dateEvent::invalidationList(Element& element, const WillBeHeapVector<RefPtrWillB eMember<InvalidationSet>>& invalidationList) 250 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorStyleInvalidatorInvali dateEvent::invalidationList(Element& element, const Vector<RefPtr<InvalidationSe t>>& invalidationList)
251 { 251 {
252 RefPtr<TracedValue> value = fillCommonPart(element, ElementHasPendingInvalid ationList); 252 RefPtr<TracedValue> value = fillCommonPart(element, ElementHasPendingInvalid ationList);
253 value->beginArray("invalidationList"); 253 value->beginArray("invalidationList");
254 for (const auto& invalidationSet : invalidationList) 254 for (const auto& invalidationSet : invalidationList)
255 invalidationSet->toTracedValue(value.get()); 255 invalidationSet->toTracedValue(value.get());
256 value->endArray(); 256 value->endArray();
257 return value.release(); 257 return value.release();
258 } 258 }
259 259
260 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorStyleRecalcInvalidatio nTrackingEvent::data(Node* node, const StyleChangeReasonForTracing& reason) 260 PassRefPtr<TraceEvent::ConvertableToTraceFormat> InspectorStyleRecalcInvalidatio nTrackingEvent::data(Node* node, const StyleChangeReasonForTracing& reason)
(...skipping 561 matching lines...) Expand 10 before | Expand all | Expand 10 after
822 if (request.move()) 822 if (request.move())
823 value->setBoolean("move", true); 823 value->setBoolean("move", true);
824 if (request.listBased()) 824 if (request.listBased())
825 value->setBoolean("listBased", true); 825 value->setBoolean("listBased", true);
826 else if (Node* node = result.innerNode()) 826 else if (Node* node = result.innerNode())
827 setNodeInfo(value.get(), node, "nodeId", "nodeName"); 827 setNodeInfo(value.get(), node, "nodeId", "nodeName");
828 return value; 828 return value;
829 } 829 }
830 830
831 } 831 }
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorTraceEvents.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698