third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp - Issue 1389333003: Do not keep InvalidationSets on the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

Issue 1389333003: Do not keep InvalidationSets on the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.h ('k') | third_party/WebKit/Source/core/css/resolver/StyleResolver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

diff --git a/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp b/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

index f35d30bee26f77a0f33070c8827d67bf0049f1c8..9b25aa9cf95ccc0cde3a8948d24da1666205470e 100644

--- a/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

+++ b/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

@@ -40,7 +40,7 @@ void StyleInvalidator::invalidate(Document& document)

clearPendingInvalidations();

}

-void StyleInvalidator::scheduleInvalidation(PassRefPtrWillBeRawPtr<InvalidationSet> invalidationSet, Element& element)

+void StyleInvalidator::scheduleInvalidation(PassRefPtr<InvalidationSet> invalidationSet, Element& element)

{

ASSERT(element.inActiveDocument());

if (element.styleChangeType() >= SubtreeStyleChange)

@@ -65,7 +65,7 @@ StyleInvalidator::InvalidationList& StyleInvalidator::ensurePendingInvalidationL

{

PendingInvalidationMap::AddResult addResult = m_pendingInvalidationMap.add(&element, nullptr);

if (addResult.isNewEntry)

- addResult.storedValue->value = adoptPtrWillBeNoop(new InvalidationList);

+ addResult.storedValue->value = adoptPtr(new InvalidationList);

return *addResult.storedValue->value;

}