Issue 138433008: Revert 245226 "Nukes MessageLoop::Dispatcher"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138433008: Revert 245226 "Nukes MessageLoop::Dispatcher" (Closed)

Created:
6 years, 11 months ago by sky

Modified:
6 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 245226 "Nukes MessageLoop::Dispatcher" > Nukes MessageLoop::Dispatcher > > There is no point in this typedef now that MessagePumpDispatcher is > its own class. > > BUG=none > TEST=none > R=ben@chromium.org, darin@chromium.org > > Review URL: https://codereview.chromium.org/139593002 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245239

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -65 lines)			Patch
M	trunk/src/ash/accelerators/accelerator_dispatcher.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	trunk/src/ash/accelerators/accelerator_dispatcher.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ash/accelerators/nested_dispatcher_controller.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ash/accelerators/nested_dispatcher_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ash/accelerators/nested_dispatcher_controller_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/base/message_loop/message_loop.h	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	trunk/src/base/run_loop.h	View	3 chunks	+3 lines, -7 lines	0 comments	Download
M	trunk/src/base/run_loop.cc	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/views/simple_message_box_views.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	trunk/src/chromeos/display/output_configurator.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	trunk/src/ui/aura/client/dispatcher_client.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/ui/aura/dispatcher_win.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	trunk/src/ui/aura/env.h	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	trunk/src/ui/aura/env.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ui/aura/root_window_host_ozone.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/ui/aura/root_window_host_x11.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/ui/events/ozone/evdev/touch_event_converter_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/ui/views/controls/menu/menu_controller.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/ui/views/controls/menu/menu_controller.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ui/views/focus/accelerator_handler.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	trunk/src/ui/views/widget/desktop_aura/desktop_dispatcher_client.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ui/views/widget/desktop_aura/desktop_dispatcher_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	trunk/src/ui/views/widget/desktop_aura/desktop_root_window_host_x11.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/ui/views/widget/desktop_aura/x11_desktop_handler.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/src/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	trunk/src/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

6 years, 11 months ago (2014-01-16 17:42:45 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r245239 (tree was closed).

Expand Messages | Collapse Messages