Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: trunk/src/base/message_loop/message_loop.h

Issue 138433008: Revert 245226 "Nukes MessageLoop::Dispatcher" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/ash/accelerators/nested_dispatcher_controller_unittest.cc ('k') | trunk/src/base/run_loop.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/base/message_loop/message_loop.h
===================================================================
--- trunk/src/base/message_loop/message_loop.h (revision 245238)
+++ trunk/src/base/message_loop/message_loop.h (working copy)
@@ -25,8 +25,9 @@
#include "base/time/time.h"
#include "base/tracking_info.h"
-// TODO(sky): these includes should not be necessary. Nuke them.
#if defined(OS_WIN)
+// We need this to declare base::MessagePumpWin::Dispatcher, which we should
+// really just eliminate.
#include "base/message_loop/message_pump_win.h"
#elif defined(OS_IOS)
#include "base/message_loop/message_pump_io_ios.h"
@@ -52,6 +53,7 @@
namespace base {
class HistogramBase;
+class MessagePumpDispatcher;
class MessagePumpObserver;
class RunLoop;
class ThreadTaskRunnerHandle;
@@ -95,6 +97,7 @@
public:
#if defined(USE_AURA)
+ typedef MessagePumpDispatcher Dispatcher;
typedef MessagePumpObserver Observer;
#elif defined(USE_GTK_MESSAGE_PUMP)
typedef MessagePumpGdkObserver Observer;
« no previous file with comments | « trunk/src/ash/accelerators/nested_dispatcher_controller_unittest.cc ('k') | trunk/src/base/run_loop.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698