Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 139593002: Nukes MessageLoop::Dispatcher (Closed)

Created:
6 years, 11 months ago by sky
Modified:
6 years, 11 months ago
CC:
chromium-reviews, rjkroege, ozone-reviews_chromium.org, sadrul, tfarina, ben+aura_chromium.org, dcheng, oshima+watch_chromium.org, kalyank, ben+views_chromium.org, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Nukes MessageLoop::Dispatcher There is no point in this typedef now that MessagePumpDispatcher is its own class. BUG=none TEST=none R=ben@chromium.org, darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -55 lines) Patch
M ash/accelerators/accelerator_dispatcher.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ash/accelerators/accelerator_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/nested_dispatcher_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/nested_dispatcher_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/nested_dispatcher_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/message_loop/message_loop.h View 3 chunks +1 line, -4 lines 0 comments Download
M base/run_loop.h View 3 chunks +7 lines, -3 lines 0 comments Download
M base/run_loop.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/simple_message_box_views.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chromeos/display/output_configurator.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/aura/client/dispatcher_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/dispatcher_win.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/env.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/env.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/root_window_host_ozone.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/root_window_host_x11.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/focus/accelerator_handler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_dispatcher_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_dispatcher_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
sky
darin: base ben: the rest
6 years, 11 months ago (2014-01-15 16:30:34 UTC) #1
Ben Goodger (Google)
Cool! LGTM for the conversions.
6 years, 11 months ago (2014-01-15 19:09:52 UTC) #2
darin (slow to review)
base/ LGTM
6 years, 11 months ago (2014-01-15 19:12:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/139593002/1
6 years, 11 months ago (2014-01-15 21:47:11 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 11 months ago (2014-01-15 23:49:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/139593002/1
6 years, 11 months ago (2014-01-16 02:12:51 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=67839
6 years, 11 months ago (2014-01-16 04:04:40 UTC) #7
sky
6 years, 11 months ago (2014-01-16 17:25:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r245226 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698