Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1383673003:
Fletch 0.1.0 documentation (Closed)
|
Created:
5 years, 2 months ago by mit Modified:
4 years, 4 months ago Base URL:
https://github.com/dart-lang/fletch.git@gh-pages Target Ref:
refs/heads/gh-pages Visibility:
Public. |
DescriptionDocs v1
Fixed #167
R=sgjesse@google.com, wibling@google.com
Committed: https://github.com/dart-lang/fletch/commit/15ebe5e15aaf098eec4b1d32e57bbd44af6c0bfb
Patch Set 1 #
Total comments: 84
Patch Set 2 : Incorporated feedback #
Total comments: 4
Patch Set 3 : Fix SDK URLs #
Total comments: 8
Patch Set 4 : tool.md feedback changes #Patch Set 5 : Fix link per Ian's feedback #
Messages
Total messages: 18 (5 generated)
mit@google.com changed reviewers: + fletch+reviews@googlegroups.com
kasperl@google.com changed reviewers: + kasperl@google.com
https://codereview.chromium.org/1383673003/diff/1/_layouts/page.html File _layouts/page.html (right): https://codereview.chromium.org/1383673003/diff/1/_layouts/page.html#newcode29 _layouts/page.html:29: <p class="header">Fast, flexible, and productive</p> I'd suggest "Fast, flexible, and productive development for devices."
https://codereview.chromium.org/1383673003/diff/1/feedback.md File feedback.md (right): https://codereview.chromium.org/1383673003/diff/1/feedback.md#newcode8 feedback.md:8: Fletch is still in it’s infancy, so we would love your feedback. Tell us what it's -> its
wibling@google.com changed reviewers: + wibling@google.com
LGTM. I have a few nits below for you to do with as you please :) https://codereview.chromium.org/1383673003/diff/1/faq.md File faq.md (right): https://codereview.chromium.org/1383673003/diff/1/faq.md#newcode29 faq.md:29: no Windows support yet), and as its only target device the [R]aspberry Pi 2 NIT: I would move "as its only target device" after the "Raspberry Pi 2 Model B". https://codereview.chromium.org/1383673003/diff/1/index.md File index.md (right): https://codereview.chromium.org/1383673003/diff/1/index.md#newcode15 index.md:15: embedded devices. Note that the current early version of Fletch supports only a NIT: I would swap "supports" and "only" https://codereview.chromium.org/1383673003/diff/1/index.md#newcode16 index.md:16: single embedded device -- the Raspberry Pi 2 -- and that the only supported NIT: I would remove "that" https://codereview.chromium.org/1383673003/diff/1/index.md#newcode18 index.md:18: no Windows support). yet? or is that promising too much? https://codereview.chromium.org/1383673003/diff/1/index.md#newcode20 index.md:20: If you just want to get a look at what Fletch programs look like, take a peak at peak -> peek https://codereview.chromium.org/1383673003/diff/1/index.md#newcode32 index.md:32: matches the OS of the PC you will be developing your code on: Perhaps change "be developing your code on" to "be using for development". https://codereview.chromium.org/1383673003/diff/1/index.md#newcode40 index.md:40: Unzip this, and make sure that the Fletch command is in path by typing this in a NIT: remove "that" "path" -> "the path" Perhaps "this" -> "the below" https://codereview.chromium.org/1383673003/diff/1/index.md#newcode49 index.md:49: Test that the Fletch program works, it should print a version number to the console: NIT: remove "that" https://codereview.chromium.org/1383673003/diff/1/index.md#newcode65 index.md:65: You should see output that looks like this on your screen: Perhaps: "this" -> "the below" https://codereview.chromium.org/1383673003/diff/1/index.md#newcode89 index.md:89: In this first step we will get a copy of the Raspberry operating system, and get NIT: Either "Raspberry Pi 2's" or "Raspbian" instead of "Raspberry" https://codereview.chromium.org/1383673003/diff/1/index.md#newcode106 index.md:106: add a second Ethernet adapter to your developer PC and connect to the NIT: missing a "can" between "you" and "add" https://codereview.chromium.org/1383673003/diff/1/index.md#newcode114 index.md:114: * Note down the IP as we will be using it below. You could also mention that the user can assign a static IP address if they have a monitor and a keyboard in the case they don't have a dhcp server. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode126 index.md:126: * Go back to System Preferences and pick the Sharing icon Perhaps also mention "Enable sharing for the USB Ethernet Adapter" https://codereview.chromium.org/1383673003/diff/1/index.md#newcode155 index.md:155: The Fletch platform is now available on the Raspberry Pi 2. Let’s make our Hello NIT: Consistent use of "Raspberry Pi 2" or "Raspberry Pi". You know which one I prefer ;) https://codereview.chromium.org/1383673003/diff/1/index.md#newcode173 index.md:173: Do you notice the difference? As before Fletch compiled the hello.dart program NIT: Do -> Did You have talked in past tense in most of the above and below. https://codereview.chromium.org/1383673003/diff/1/samples.md File samples.md (right): https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode109 samples.md:109: // Initialize button pin. Enable a button down trigger. NIT: Is it a button down trigger when we enable both? https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode162 samples.md:162: only be accessed from within the class itself (i.e., that is encapsulated to the NIT: It can be accessed from within the Dart library (ie. from all code that is using the same library statement. https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode239 samples.md:239: ** TODO ** Remove this? https://codereview.chromium.org/1383673003/diff/1/tool.md File tool.md (right): https://codereview.chromium.org/1383673003/diff/1/tool.md#newcode18 tool.md:18: **TODO** Do we want to show this?
sgjesse@google.com changed reviewers: + sgjesse@google.com
lgtm, with comments https://codereview.chromium.org/1383673003/diff/1/faq.md File faq.md (right): https://codereview.chromium.org/1383673003/diff/1/faq.md#newcode17 faq.md:17: development for devices. It is powered by the [Dart Maybe clarify "device" https://codereview.chromium.org/1383673003/diff/1/faq.md#newcode22 faq.md:22: * *A*: Fletch is an experimental project in the pre-alpha phase. Things are still nit: long line https://codereview.chromium.org/1383673003/diff/1/faq.md#newcode29 faq.md:29: no Windows support yet), and as its only target device the [R]aspberry Pi 2 Shouldn't the ] after R be removed - or is there some markdown feature I don't know about. https://codereview.chromium.org/1383673003/diff/1/index.md File index.md (right): https://codereview.chromium.org/1383673003/diff/1/index.md#newcode26 index.md:26: * [Running on the Raspberry Pi](#running-on-the-raspberry-pi) Add 2 here as well? https://codereview.chromium.org/1383673003/diff/1/index.md#newcode31 index.md:31: First download the SDK. This is available as a .zip archive; pick the one that `s around .zip https://codereview.chromium.org/1383673003/diff/1/index.md#newcode71 index.md:71: Try to open ```hello.dart``` in your favorite editor. We recommend the Atom Isn't just one ` sufficient here? https://codereview.chromium.org/1383673003/diff/1/index.md#newcode72 index.md:72: editor by Github with the Dart plugin. Pretty easy to read, right? With the analyzer not supported you will see a bunch of errors for fletch projects though. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode83 index.md:83: Now let’s get things running on your Raspberry! Maybe add a paragraph: If you already have a working Raspberry Pi 2 installed with a recent Raspbian you can skip to Step 3. The only requirements are that the Raspberry Pi 2 has an IP address and you can access it from your development machine. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode128 index.md:128: * After a little while you should be able to ping the Raspberry Pi at ```192.168.2.2``` Is the Mac acting as a DHCP server always assigning 192.168.2.2 in this case? https://codereview.chromium.org/1383673003/diff/1/index.md#newcode137 index.md:137: A. Copy the fletch package to the Raspberry Pi (the default password for fletch package -> fletch-agent package. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode138 index.md:138: Raspbian is 'raspberry'): for Raspbian -> for user 'pi' on Raspbian https://codereview.chromium.org/1383673003/diff/1/index.md#newcode156 index.md:156: program run again, this time on the Raspberry Pi 2. Type the following command on nit: long line https://codereview.chromium.org/1383673003/diff/1/samples.md File samples.md (right): https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode22 samples.md:22: communication with these happens via the happens -> typically happens the -> a https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode24 samples.md:24: purpose input/output) protocol. protocol -> interface https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode27 samples.md:27: folder. This uses GPIO to blink the Raspberry Pi on-board LED. It doesn't use GPIO any more, but the sysfs interface to RPi on-board leds. https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode32 samples.md:32: pi.leds.activityLED.setMode(OnboardLEDMode.gpio); You askes me to change this to use the other interface - should we change it back to GPIO? Otherwise this line is not needed anymore. https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode105 samples.md:105: SysfsGPIO gpio = new SysfsGPIO(); This was changed to: RaspberryPi pi = new RaspberryPi(); SysfsGPIO gpio = pi.sysfsGPIO; https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode109 samples.md:109: // Initialize button pin. Enable a button down trigger. On 2015/10/05 15:19:59, wibling wrote: > NIT: Is it a button down trigger when we enable both? It seemed that using the raising (or falling trigger - depending on the wiring) was somewhat unstable. We have not looked into the details. https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode143 samples.md:143: lines of initialization code, and then a small eternal loop in which we had a few nit: long line https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode168 samples.md:168: PiMemoryMappedGPIO _gpio = new PiMemoryMappedGPIO(); This initialization was refactored in https://codereview.chromium.org/1389573002/diff/80001/samples/raspberry_pi/ba.... https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode224 samples.md:224: // Initialize the lights controller class. Again see https://codereview.chromium.org/1389573002/diff/80001/samples/raspberry_pi/ba... for the refactor.
https://codereview.chromium.org/1383673003/diff/1/_layouts/page.html File _layouts/page.html (right): https://codereview.chromium.org/1383673003/diff/1/_layouts/page.html#newcode29 _layouts/page.html:29: <p class="header">Fast, flexible, and productive</p> On 2015/10/05 14:49:39, kasperl wrote: > I'd suggest "Fast, flexible, and productive development for devices." Done. https://codereview.chromium.org/1383673003/diff/1/faq.md File faq.md (right): https://codereview.chromium.org/1383673003/diff/1/faq.md#newcode17 faq.md:17: development for devices. It is powered by the [Dart On 2015/10/05 16:19:50, Søren Gjesse wrote: > Maybe clarify "device" Done. https://codereview.chromium.org/1383673003/diff/1/faq.md#newcode22 faq.md:22: * *A*: Fletch is an experimental project in the pre-alpha phase. Things are still On 2015/10/05 16:19:50, Søren Gjesse wrote: > nit: long line Done. https://codereview.chromium.org/1383673003/diff/1/faq.md#newcode29 faq.md:29: no Windows support yet), and as its only target device the [R]aspberry Pi 2 On 2015/10/05 16:19:50, Søren Gjesse wrote: > Shouldn't the ] after R be removed - or is there some markdown feature I don't > know about. Done. https://codereview.chromium.org/1383673003/diff/1/faq.md#newcode29 faq.md:29: no Windows support yet), and as its only target device the [R]aspberry Pi 2 On 2015/10/05 15:19:58, wibling wrote: > NIT: I would move "as its only target device" after the "Raspberry Pi 2 Model > B". Done. https://codereview.chromium.org/1383673003/diff/1/feedback.md File feedback.md (right): https://codereview.chromium.org/1383673003/diff/1/feedback.md#newcode8 feedback.md:8: Fletch is still in it’s infancy, so we would love your feedback. Tell us what On 2015/10/05 14:52:55, kasperl wrote: > it's -> its Done. https://codereview.chromium.org/1383673003/diff/1/index.md File index.md (right): https://codereview.chromium.org/1383673003/diff/1/index.md#newcode15 index.md:15: embedded devices. Note that the current early version of Fletch supports only a On 2015/10/05 15:19:59, wibling wrote: > NIT: I would swap "supports" and "only" Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode16 index.md:16: single embedded device -- the Raspberry Pi 2 -- and that the only supported On 2015/10/05 15:19:59, wibling wrote: > NIT: I would remove "that" Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode18 index.md:18: no Windows support). On 2015/10/05 15:19:59, wibling wrote: > yet? or is that promising too much? I think so, let's just leave it as is until we understand the timeline for Windows support... https://codereview.chromium.org/1383673003/diff/1/index.md#newcode20 index.md:20: If you just want to get a look at what Fletch programs look like, take a peak at On 2015/10/05 15:19:59, wibling wrote: > peak -> peek Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode26 index.md:26: * [Running on the Raspberry Pi](#running-on-the-raspberry-pi) On 2015/10/05 16:19:51, Søren Gjesse wrote: > Add 2 here as well? Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode31 index.md:31: First download the SDK. This is available as a .zip archive; pick the one that On 2015/10/05 16:19:51, Søren Gjesse wrote: > `s around .zip Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode32 index.md:32: matches the OS of the PC you will be developing your code on: On 2015/10/05 15:19:58, wibling wrote: > Perhaps change "be developing your code on" to "be using for development". Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode40 index.md:40: Unzip this, and make sure that the Fletch command is in path by typing this in a On 2015/10/05 15:19:59, wibling wrote: > NIT: remove "that" > > "path" -> "the path" > > Perhaps "this" -> "the below" Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode49 index.md:49: Test that the Fletch program works, it should print a version number to the console: On 2015/10/05 15:19:59, wibling wrote: > NIT: remove "that" Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode65 index.md:65: You should see output that looks like this on your screen: On 2015/10/05 15:19:59, wibling wrote: > Perhaps: "this" -> "the below" Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode71 index.md:71: Try to open ```hello.dart``` in your favorite editor. We recommend the Atom On 2015/10/05 16:19:51, Søren Gjesse wrote: > Isn't just one ` sufficient here? Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode72 index.md:72: editor by Github with the Dart plugin. Pretty easy to read, right? On 2015/10/05 16:19:51, Søren Gjesse wrote: > With the analyzer not supported you will see a bunch of errors for fletch > projects though. Yes, added a note, and filed an enhancement bug to track this. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode83 index.md:83: Now let’s get things running on your Raspberry! On 2015/10/05 16:19:51, Søren Gjesse wrote: > Maybe add a paragraph: > > If you already have a working Raspberry Pi 2 installed with a recent Raspbian > you can skip to Step 3. The only requirements are that the Raspberry Pi 2 has an > IP address and you can access it from your development machine. Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode89 index.md:89: In this first step we will get a copy of the Raspberry operating system, and get On 2015/10/05 15:19:59, wibling wrote: > NIT: Either "Raspberry Pi 2's" or "Raspbian" instead of "Raspberry" Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode89 index.md:89: In this first step we will get a copy of the Raspberry operating system, and get On 2015/10/05 15:19:59, wibling wrote: > NIT: Either "Raspberry Pi 2's" or "Raspbian" instead of "Raspberry" Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode106 index.md:106: add a second Ethernet adapter to your developer PC and connect to the On 2015/10/05 15:19:59, wibling wrote: > NIT: missing a "can" between "you" and "add" Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode114 index.md:114: * Note down the IP as we will be using it below. On 2015/10/05 15:19:59, wibling wrote: > You could also mention that the user can assign a static IP address if they have > a monitor and a keyboard in the case they don't have a dhcp server. Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode126 index.md:126: * Go back to System Preferences and pick the Sharing icon On 2015/10/05 15:19:59, wibling wrote: > Perhaps also mention "Enable sharing for the USB Ethernet Adapter" Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode128 index.md:128: * After a little while you should be able to ping the Raspberry Pi at ```192.168.2.2``` On 2015/10/05 16:19:51, Søren Gjesse wrote: > Is the Mac acting as a DHCP server always assigning 192.168.2.2 in this case? Yup. (That is, assuming the Raspberry is the first only network device plugged into the Mac). https://codereview.chromium.org/1383673003/diff/1/index.md#newcode137 index.md:137: A. Copy the fletch package to the Raspberry Pi (the default password for On 2015/10/05 16:19:51, Søren Gjesse wrote: > fletch package -> fletch-agent package. Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode138 index.md:138: Raspbian is 'raspberry'): On 2015/10/05 16:19:50, Søren Gjesse wrote: > for Raspbian -> for user 'pi' on Raspbian Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode155 index.md:155: The Fletch platform is now available on the Raspberry Pi 2. Let’s make our Hello On 2015/10/05 15:19:58, wibling wrote: > NIT: Consistent use of "Raspberry Pi 2" or "Raspberry Pi". You know which one I > prefer ;) Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode156 index.md:156: program run again, this time on the Raspberry Pi 2. Type the following command on On 2015/10/05 16:19:51, Søren Gjesse wrote: > nit: long line Done. https://codereview.chromium.org/1383673003/diff/1/index.md#newcode173 index.md:173: Do you notice the difference? As before Fletch compiled the hello.dart program On 2015/10/05 15:19:59, wibling wrote: > NIT: Do -> Did > > You have talked in past tense in most of the above and below. Done. https://codereview.chromium.org/1383673003/diff/1/samples.md File samples.md (right): https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode22 samples.md:22: communication with these happens via the On 2015/10/05 16:19:51, Søren Gjesse wrote: > happens -> typically happens > the -> a Done. https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode24 samples.md:24: purpose input/output) protocol. On 2015/10/05 16:19:51, Søren Gjesse wrote: > protocol -> interface Done. https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode27 samples.md:27: folder. This uses GPIO to blink the Raspberry Pi on-board LED. On 2015/10/05 16:19:51, Søren Gjesse wrote: > It doesn't use GPIO any more, but the sysfs interface to RPi on-board leds. Yes, makes sense. I will move the GPIO comments down to the next sample. https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode32 samples.md:32: pi.leds.activityLED.setMode(OnboardLEDMode.gpio); On 2015/10/05 16:19:51, Søren Gjesse wrote: > You askes me to change this to use the other interface - should we change it > back to GPIO? Otherwise this line is not needed anymore. Don't we still need this line to tell the Raspberry to make it not be tied to SD activity? https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode105 samples.md:105: SysfsGPIO gpio = new SysfsGPIO(); On 2015/10/05 16:19:51, Søren Gjesse wrote: > This was changed to: > > RaspberryPi pi = new RaspberryPi(); > SysfsGPIO gpio = pi.sysfsGPIO; Done. https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode109 samples.md:109: // Initialize button pin. Enable a button down trigger. On 2015/10/05 15:19:59, wibling wrote: > NIT: Is it a button down trigger when we enable both? Acknowledged. https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode109 samples.md:109: // Initialize button pin. Enable a button down trigger. On 2015/10/05 16:19:51, Søren Gjesse wrote: > On 2015/10/05 15:19:59, wibling wrote: > > NIT: Is it a button down trigger when we enable both? > > It seemed that using the raising (or falling trigger - depending on the wiring) > was somewhat unstable. We have not looked into the details. Acknowledged. https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode143 samples.md:143: lines of initialization code, and then a small eternal loop in which we had a few On 2015/10/05 16:19:51, Søren Gjesse wrote: > nit: long line Done. https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode162 samples.md:162: only be accessed from within the class itself (i.e., that is encapsulated to the On 2015/10/05 15:19:59, wibling wrote: > NIT: It can be accessed from within the Dart library (ie. from all code that is > using the same library statement. Rewrote this a bit. https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode168 samples.md:168: PiMemoryMappedGPIO _gpio = new PiMemoryMappedGPIO(); On 2015/10/05 16:19:51, Søren Gjesse wrote: > This initialization was refactored in > https://codereview.chromium.org/1389573002/diff/80001/samples/raspberry_pi/ba.... Done. https://codereview.chromium.org/1383673003/diff/1/tool.md File tool.md (right): https://codereview.chromium.org/1383673003/diff/1/tool.md#newcode18 tool.md:18: **TODO** On 2015/10/05 15:19:59, wibling wrote: > Do we want to show this? See patchset 2, changed this to just talk about settings files and debugging. We should talk about mocks/testing in a later release.
LGTM, with a few additional comments on tool.md. https://codereview.chromium.org/1383673003/diff/1/samples.md File samples.md (right): https://codereview.chromium.org/1383673003/diff/1/samples.md#newcode32 samples.md:32: pi.leds.activityLED.setMode(OnboardLEDMode.gpio); On 2015/10/05 17:51:39, mit wrote: > On 2015/10/05 16:19:51, Søren Gjesse wrote: > > You askes me to change this to use the other interface - should we change it > > back to GPIO? Otherwise this line is not needed anymore. > > Don't we still need this line to tell the Raspberry to make it not be tied to SD > activity? Yes we do, sorry. https://codereview.chromium.org/1383673003/diff/40001/tool.md File tool.md (right): https://codereview.chromium.org/1383673003/diff/40001/tool.md#newcode17 tool.md:17: the tool default to a session called ```local```. The tool defaults to the last session mentioned, which starts out being 'local' $ fletch run hello.dart in session remote $ fletch run hello.dart will run twice in session 'remote'. https://codereview.chromium.org/1383673003/diff/40001/tool.md#newcode35 tool.md:35: tag. Also mention that if "device_address" is not set (or set to null) it will be a local session. https://codereview.chromium.org/1383673003/diff/40001/tool.md#newcode58 tool.md:58: b _setLeds The documentation from 'help' says 'b <method name> <bytecode index>' set breakpoint but apparently <byteconde index> defaults to 0. Opened https://github.com/dart-lang/fletch/issues/201 https://codereview.chromium.org/1383673003/diff/40001/tool.md#newcode73 tool.md:73: decrementing. Pretty neat right!? Maybe also mention the `l` command.
LGTM, with a few additional comments on tool.md.
tool.md feedback incorporated in patchset 4 https://codereview.chromium.org/1383673003/diff/40001/tool.md File tool.md (right): https://codereview.chromium.org/1383673003/diff/40001/tool.md#newcode17 tool.md:17: the tool default to a session called ```local```. On 2015/10/05 18:28:01, Søren Gjesse wrote: > The tool defaults to the last session mentioned, which starts out being 'local' > > $ fletch run hello.dart in session remote > $ fletch run hello.dart > > will run twice in session 'remote'. I doesn't seem like it works like that anymore? I tried and I get the local session again the second time. https://codereview.chromium.org/1383673003/diff/40001/tool.md#newcode58 tool.md:58: b _setLeds On 2015/10/05 18:28:01, Søren Gjesse wrote: > The documentation from 'help' says > > 'b <method name> <bytecode index>' set breakpoint > > but apparently <byteconde index> defaults to 0. > > Opened https://github.com/dart-lang/fletch/issues/201 Acknowledged. https://codereview.chromium.org/1383673003/diff/40001/tool.md#newcode73 tool.md:73: decrementing. Pretty neat right!? On 2015/10/05 18:28:01, Søren Gjesse wrote: > Maybe also mention the `l` command. I would, but it seems broken. I will open a bug tomorrow.
zerny@google.com changed reviewers: + zerny@google.com
dbc https://codereview.chromium.org/1383673003/diff/20001/index.md File index.md (right): https://codereview.chromium.org/1383673003/diff/20001/index.md#newcode166 index.md:166: fletch run ./samples/general/hello.dart in session remote Generally I'd not include the "./" when not explicitly needed, eg, for executing the first element as a script. https://codereview.chromium.org/1383673003/diff/20001/index.md#newcode189 index.md:189: more about the [Fletch tool]()tool.html. ()tool.html. -> (tool.html).
https://codereview.chromium.org/1383673003/diff/20001/index.md File index.md (right): https://codereview.chromium.org/1383673003/diff/20001/index.md#newcode166 index.md:166: fletch run ./samples/general/hello.dart in session remote On 2015/10/05 20:02:52, zerny-google wrote: > Generally I'd not include the "./" when not explicitly needed, eg, for executing > the first element as a script. Acknowledged. https://codereview.chromium.org/1383673003/diff/20001/index.md#newcode189 index.md:189: more about the [Fletch tool]()tool.html. On 2015/10/05 20:02:52, zerny-google wrote: > ()tool.html. -> (tool.html). Done.
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as 15ebe5e15aaf098eec4b1d32e57bbd44af6c0bfb (presubmit successful).
Message was sent while issue was closed.
https://codereview.chromium.org/1383673003/diff/40001/tool.md File tool.md (right): https://codereview.chromium.org/1383673003/diff/40001/tool.md#newcode17 tool.md:17: the tool default to a session called ```local```. On 2015/10/05 20:02:49, mit wrote: > On 2015/10/05 18:28:01, Søren Gjesse wrote: > > The tool defaults to the last session mentioned, which starts out being > 'local' > > > > $ fletch run hello.dart in session remote > > $ fletch run hello.dart > > > > will run twice in session 'remote'. > > I doesn't seem like it works like that anymore? I tried and I get the local > session again the second time. I believe Peter changed the semantics of the default session to always be the local session. Other sessions will have to be specified with "in session". There is a plan to add a command to change the default session. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
