build/android/devil/android/device_utils_test.py - Issue 1382413002: DeviceUtils._PushChangedFilesZipped: use default temp file directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/devil/android/device_utils_test.py

Issue 1382413002: DeviceUtils._PushChangedFilesZipped: use default temp file directory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/devil/android/device_utils_test.py

diff --git a/build/android/devil/android/device_utils_test.py b/build/android/devil/android/device_utils_test.py

index 5eb0525e42d7c2e81b7b6975726a28e5c6ef849c..4cb4591843ea85c3302d756871f1ce45bdc2ebff 100755

--- a/build/android/devil/android/device_utils_test.py

+++ b/build/android/devil/android/device_utils_test.py

@@ -1446,9 +1446,8 @@ class DeviceUtilsPushChangedFilesZippedTest(DeviceUtilsTest):

args=('/test/temp/file/tmp.zip', test_files)), mock.Mock()),

(self.call.device._MaybeInstallCommands(), True),

(self.call.device.NeedsSU(), True),

- (self.call.device.GetExternalStoragePath(), '/test/sdcard'),

(mock.call.devil.android.device_temp_file.DeviceTempFile(self.adb,

- suffix='.zip', dir='/test/sdcard'),

+ suffix='.zip'),

MockTempFile('/test/sdcard/foo123.zip')),

self.call.adb.Push(

'/test/temp/file/tmp.zip', '/test/sdcard/foo123.zip'),

« no previous file with comments | « build/android/devil/android/device_utils.py ('k') | no next file » | no next file with comments »