build/android/devil/android/device_utils.py - Issue 1382413002: DeviceUtils._PushChangedFilesZipped: use default temp file directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/devil/android/device_utils.py

Issue 1382413002: DeviceUtils._PushChangedFilesZipped: use default temp file directory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/devil/android/device_utils.py

diff --git a/build/android/devil/android/device_utils.py b/build/android/devil/android/device_utils.py

index 96de1f88ede2a293f61d19c1d0940c4614ea2082..e7bf297f0e9f73424897f7feaaa3db24d5afa222 100644

--- a/build/android/devil/android/device_utils.py

+++ b/build/android/devil/android/device_utils.py

@@ -1250,9 +1250,8 @@ class DeviceUtils(object):

# Warm up NeedsSU cache while we're still zipping.

self.NeedsSU()

- external_dir = self.GetExternalStoragePath()

with device_temp_file.DeviceTempFile(

- self.adb, suffix='.zip', dir=external_dir) as device_temp:

+ self.adb, suffix='.zip') as device_temp:

zip_proc.join()

self.adb.Push(zip_file.name, device_temp.name)

quoted_dirs = ' '.join(cmd_helper.SingleQuote(d) for d in dirs)

« no previous file with comments | « no previous file | build/android/devil/android/device_utils_test.py » ('j') | no next file with comments »