Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 1381023003: permissions: add layout tests for multiple requests (Closed)

Created:
2 years, 1 month ago by Lalit Maganti
Modified:
2 years, 1 month ago
CC:
blink-reviews, chromium-reviews, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

permissions: add layout tests for multiple requests No permisisons, single, multiple and duplicate permissions are all tested. Permission updates being reflected in the request is also tested. BUG=516626 Committed: https://crrev.com/4a5a84a2a326cecc6d183478ca684aea753adc18 Cr-Commit-Position: refs/heads/master@{#352015}

Patch Set 1 #

Patch Set 2 : Fix subtle issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -7 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/permissions/chromium/resources/test-request-multiple.js View 1 1 chunk +235 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-sharedworker.html View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-window.html View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-worker.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/permissions/Permissions.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Lalit Maganti
Mounir: I've throughly combed for the failure manually and I really can't see what could ...
2 years, 1 month ago (2015-10-01 16:05:46 UTC) #2
mlamouri (slow - plz ping)
lgtm
2 years, 1 month ago (2015-10-02 10:32:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381023003/20001
2 years, 1 month ago (2015-10-02 10:34:10 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
2 years, 1 month ago (2015-10-02 13:10:34 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4a5a84a2a326cecc6d183478ca684aea753adc18 Cr-Commit-Position: refs/heads/master@{#352015}
2 years, 1 month ago (2015-10-02 13:11:22 UTC) #7
dmurph
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1377723005/ by dmurph@chromium.org. ...
2 years, 1 month ago (2015-10-02 19:04:37 UTC) #8
dmurph
2 years, 1 month ago (2015-10-02 20:25:09 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1376523006/ by dmurph@chromium.org.

The reason for reverting is: BUG=538717.

Powered by Google App Engine
This is Rietveld efc10ee0f