third_party/WebKit/Source/modules/permissions/Permissions.cpp - Issue 1381023003: permissions: add layout tests for multiple requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/permissions/Permissions.cpp

Issue 1381023003: permissions: add layout tests for multiple requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix subtle issues Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/permissions/Permissions.cpp

diff --git a/third_party/WebKit/Source/modules/permissions/Permissions.cpp b/third_party/WebKit/Source/modules/permissions/Permissions.cpp

index bd4029f2dd1cdca36636a84dfad180516d561838..1e6acc2955aa3b4d4b2b90709071b412f07f32df 100644

--- a/third_party/WebKit/Source/modules/permissions/Permissions.cpp

+++ b/third_party/WebKit/Source/modules/permissions/Permissions.cpp

@@ -160,7 +160,8 @@ ScriptPromise Permissions::request(ScriptState* scriptState, const Vector<Dictio

ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

- client->requestPermissions(*permissions, KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()), new PermissionsCallback(resolver, permissions.release()));

+ WebVector<WebPermissionType> permissionsCopy = *permissions;

+ client->requestPermissions(permissionsCopy, KURL(KURL(), scriptState->executionContext()->securityOrigin()->toString()), new PermissionsCallback(resolver, permissions.release()));

return promise;

}

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/permissions/chromium/test-request-multiple-worker.html ('k') | no next file » | no next file with comments »