Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1376523006: Revert of permissions: add layout tests for multiple requests (Closed)

Created:
5 years, 2 months ago by dmurph
Modified:
5 years, 2 months ago
CC:
blink-reviews, chromium-reviews, mlamouri+watch-blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of permissions: add layout tests for multiple requests (patchset #2 id:20001 of https://codereview.chromium.org/1381023003/ ) Reason for revert: BUG=538717 Original issue's description: > permissions: add layout tests for multiple requests > > No permisisons, single, multiple and duplicate permissions > are all tested. Permission updates being reflected in the request > is also tested. > > BUG=516626 > > Committed: https://crrev.com/4a5a84a2a326cecc6d183478ca684aea753adc18 > Cr-Commit-Position: refs/heads/master@{#352015} TBR=mlamouri@chromium.org,lalitm@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=516626 Committed: https://crrev.com/0adc11742287c2af556837823aebccd8c2961bc4 Cr-Commit-Position: refs/heads/master@{#352115}

Patch Set 1 #

Messages

Total messages: 6 (1 generated)
dmurph
Created Revert of permissions: add layout tests for multiple requests
5 years, 2 months ago (2015-10-02 20:25:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1376523006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1376523006/1
5 years, 2 months ago (2015-10-02 20:25:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-02 20:29:20 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0adc11742287c2af556837823aebccd8c2961bc4 Cr-Commit-Position: refs/heads/master@{#352115}
5 years, 2 months ago (2015-10-02 20:30:55 UTC) #5
mlamouri (slow - plz ping)
5 years, 2 months ago (2015-10-03 14:51:27 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1384163002/ by mlamouri@chromium.org.

The reason for reverting is: Relanding and disabling the test on Win 7 in order
to have tests and investigate the problem..

Powered by Google App Engine
This is Rietveld 408576698