Issue 1380253003: Issue 24420. Don't allow renaming in pub packages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1380253003: Issue 24420. Don't allow renaming in pub packages. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -0 lines)			Patch
M	pkg/analysis_server/lib/src/services/refactoring/rename.dart	View	4 chunks	+37 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart	View	1 chunk	+37 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart	View	1 chunk	+42 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Brian Wilkerson

I agree that this is really ugly. I still think this should be a client ...

5 years, 2 months ago (2015-10-02 20:04:20 UTC) #2

scheglov

5 years, 2 months ago (2015-10-02 20:09:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c06ad0db3040099d5427dd2b7243e327bce403ee (presubmit successful).