Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart

Issue 1380253003: Issue 24420. Don't allow renaming in pub packages. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart b/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
index 4c799d18f6a228ffe13ee9fedcd1abe42f44bea4..8e38f8fd8ecb4553926e59f36a01bfb8a2fb180e 100644
--- a/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart
@@ -224,6 +224,48 @@ class B {
assertRefactoringStatusOK(status);
}
+ test_checkInitialConditions_inPubCache_posix() async {
+ addSource(
+ '/.pub-cache/lib.dart',
+ r'''
+class A {}
+''');
+ indexTestUnit('''
+import '/.pub-cache/lib.dart';
+main() {
+ A a;
+}
+''');
+ createRenameRefactoringAtString('A a');
+ // check status
+ refactoring.newName = 'NewName';
+ RefactoringStatus status = await refactoring.checkInitialConditions();
+ assertRefactoringStatus(status, RefactoringProblemSeverity.FATAL,
+ expectedMessage:
+ "The class 'A' is defined in a pub package, so cannot be renamed.");
+ }
+
+ test_checkInitialConditions_inPubCache_windows() async {
+ addSource(
+ '/Pub/Cache/lib.dart',
+ r'''
+class A {}
+''');
+ indexTestUnit('''
+import '/Pub/Cache/lib.dart';
+main() {
+ A a;
+}
+''');
+ createRenameRefactoringAtString('A a');
+ // check status
+ refactoring.newName = 'NewName';
+ RefactoringStatus status = await refactoring.checkInitialConditions();
+ assertRefactoringStatus(status, RefactoringProblemSeverity.FATAL,
+ expectedMessage:
+ "The class 'A' is defined in a pub package, so cannot be renamed.");
+ }
+
test_checkInitialConditions_inSDK() async {
indexTestUnit('''
main() {
« no previous file with comments | « pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698