Issue 24420. Don't allow renaming in pub packages.

pkg/analysis_server/lib/src/services/refactoring/rename.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.src.refactoring.rename;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol_server.dart' hide Element;
 import 'package:analysis_server/src/services/correction/source_range.dart';
 import 'package:analysis_server/src/services/correction/status.dart';
 import 'package:analysis_server/src/services/correction/util.dart';
 import 'package:analysis_server/src/services/refactoring/refactoring.dart';
 import 'package:analysis_server/src/services/refactoring/refactoring_internal.dart';
 import 'package:analysis_server/src/services/search/search_engine.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/java_core.dart';
 import 'package:analyzer/src/generated/source.dart';
+import 'package:path/path.dart' as pathos;
 
 /**
  * Returns `true` if two given [Element]s are [LocalElement]s and have
  * intersecting with visibility ranges.
  */
 bool haveIntersectingRanges(LocalElement localElement, Element element) {
   if (element is! LocalElement) {
     return false;
   }
   LocalElement localElement2 = element as LocalElement;
@@ skipping 15 matching lines @@
   // should be the same AnalysisContext
   if (!isInContext(element, context)) {
     return false;
   }
   // private elements are visible only in their library
   List<Source> librarySourcesOfSource = context.getLibrariesContaining(source);
   Source librarySourceOfElement = element.library.source;
   return librarySourcesOfSource.contains(librarySourceOfElement);
 }
 
+bool isElementInPubCache(Element element) {
+  Source source = element.source;
+  String path = source.fullName;
+  return isPathInPubCache(path);
+}
+
+bool isElementInSdkOrPubCache(Element element) {
+  Source source = element.source;
+  String path = source.fullName;
+  return source.isInSystemLibrary || isPathInPubCache(path);
+}
+
 /**
  * Checks if the given [Element] is in the given [AnalysisContext].
  */
 bool isInContext(Element element, AnalysisContext context) {
   return element.context == context;
 }
 
+bool isPathInPubCache(String path) {
+  List<String> parts = pathos.split(path);
+  if (parts.contains('.pub-cache')) {
+    return true;
+  }
+  for (int i = 0; i < parts.length - 1; i++) {
+    if (parts[i] == 'Pub' && parts[i + 1] == 'Cache') {
+      return true;
+    }
+    if (parts[i] == 'third_party' &&
+        (parts[i + 1] == 'pkg' || parts[i + 1] == 'pkg_tested')) {
+      return true;
+    }
+  }
+  return false;
+}
+
 /**
  * Checks if the given unqualified [SearchMatch] intersects with visibility
  * range of [localElement].
  */
 bool isReferenceInLocalRange(LocalElement localElement, SearchMatch reference) {
   if (reference.isQualified) {
     return false;
   }
   Source localSource = localElement.source;
   Source referenceSource = reference.element.source;
@@ skipping 66 matching lines @@
   @override
   Future<RefactoringStatus> checkInitialConditions() {
     RefactoringStatus result = new RefactoringStatus();
     if (element.source.isInSystemLibrary) {
       String message = format(
           "The {0} '{1}' is defined in the SDK, so cannot be renamed.",
           getElementKindName(element),
           getElementQualifiedName(element));
       result.addFatalError(message);
     }
+    if (isElementInPubCache(element)) {
+      String message = format(
+          "The {0} '{1}' is defined in a pub package, so cannot be renamed.",
+          getElementKindName(element),
+          getElementQualifiedName(element));
+      result.addFatalError(message);
+    }
     return new Future.value(result);
   }
 
   @override
   RefactoringStatus checkNewName() {
     RefactoringStatus result = new RefactoringStatus();
     if (newName == oldName) {
       result.addFatalError(
           "The new name must be different than the current name.");
     }
@@ skipping 22 matching lines @@
     if (element is ImportElement) {
       PrefixElement prefix = element.prefix;
       if (prefix != null) {
         return prefix.displayName;
       }
       return '';
     }
     return element.displayName;
   }
 }