pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart - Issue 1380253003: Issue 24420. Don't allow renaming in pub packages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

Issue 1380253003: Issue 24420. Don't allow renaming in pub packages. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/refactoring/rename.dart ('k') | pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

index e0f9a7717f203b400678e62817eaa5cc44152409..4d70e0625c2da07b749269ebb2ea2864417ddd73 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart

@@ -100,6 +100,11 @@ class RenameClassMemberRefactoringImpl extends RenameRefactoringImpl {

if (reference.isResolved) {

continue;

}

+ // ignore references from SDK and pub cache

+ if (isElementInSdkOrPubCache(reference.element)) {

+ print('ignore: $reference');

+ continue;

+ }

// check the element being renamed is accessible

{

LibraryElement whereLibrary = reference.element.library;