chrome/browser/extensions/api/runtime/runtime_apitest.cc - Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/runtime/runtime_apitest.cc

Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix ExtensionManagementApiBrowserTest.LaunchApp Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/management_apitest.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/runtime/runtime_apitest.cc

diff --git a/chrome/browser/extensions/api/runtime/runtime_apitest.cc b/chrome/browser/extensions/api/runtime/runtime_apitest.cc

index 0c78b19b748a51af7d3f057497c5b18420d3c000..398989e777899bd06caf035204db2f9b4f61e77d 100644

--- a/chrome/browser/extensions/api/runtime/runtime_apitest.cc

+++ b/chrome/browser/extensions/api/runtime/runtime_apitest.cc

@@ -3,6 +3,7 @@

// found in the LICENSE file.

#include "chrome/browser/apps/app_browsertest_util.h"

+#include "chrome/browser/extensions/api/management/management_api.h"

#include "chrome/browser/extensions/api/runtime/runtime_api.h"

#include "chrome/browser/extensions/extension_apitest.h"

#include "chrome/browser/extensions/extension_function_test_utils.h"

@@ -28,6 +29,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeUnprivileged) {

}

IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeUninstallURL) {

+ // Auto-confirm the uninstall dialog.

+ extensions::ManagementUninstallFunction::SetAutoConfirmForTest(true);

ASSERT_TRUE(LoadExtension(

test_data_dir_.AppendASCII("runtime").AppendASCII("uninstall_url").

AppendASCII("sets_uninstall_url")));