Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: chrome/browser/extensions/api/runtime/runtime_apitest.cc

Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix ExtensionManagementApiBrowserTest.LaunchApp Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/apps/app_browsertest_util.h" 5 #include "chrome/browser/apps/app_browsertest_util.h"
6 #include "chrome/browser/extensions/api/management/management_api.h"
6 #include "chrome/browser/extensions/api/runtime/runtime_api.h" 7 #include "chrome/browser/extensions/api/runtime/runtime_api.h"
7 #include "chrome/browser/extensions/extension_apitest.h" 8 #include "chrome/browser/extensions/extension_apitest.h"
8 #include "chrome/browser/extensions/extension_function_test_utils.h" 9 #include "chrome/browser/extensions/extension_function_test_utils.h"
9 #include "chrome/test/base/ui_test_utils.h" 10 #include "chrome/test/base/ui_test_utils.h"
10 #include "net/test/embedded_test_server/embedded_test_server.h" 11 #include "net/test/embedded_test_server/embedded_test_server.h"
11 12
12 // Tests the privileged components of chrome.runtime. 13 // Tests the privileged components of chrome.runtime.
13 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimePrivileged) { 14 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimePrivileged) {
14 ASSERT_TRUE(RunExtensionTest("runtime/privileged")) << message_; 15 ASSERT_TRUE(RunExtensionTest("runtime/privileged")) << message_;
15 } 16 }
16 17
17 // Tests the unprivileged components of chrome.runtime. 18 // Tests the unprivileged components of chrome.runtime.
18 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeUnprivileged) { 19 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeUnprivileged) {
19 ASSERT_TRUE(StartEmbeddedTestServer()); 20 ASSERT_TRUE(StartEmbeddedTestServer());
20 ASSERT_TRUE( 21 ASSERT_TRUE(
21 LoadExtension(test_data_dir_.AppendASCII("runtime/content_script"))); 22 LoadExtension(test_data_dir_.AppendASCII("runtime/content_script")));
22 23
23 // The content script runs on webpage.html. 24 // The content script runs on webpage.html.
24 ResultCatcher catcher; 25 ResultCatcher catcher;
25 ui_test_utils::NavigateToURL(browser(), 26 ui_test_utils::NavigateToURL(browser(),
26 embedded_test_server()->GetURL("/webpage.html")); 27 embedded_test_server()->GetURL("/webpage.html"));
27 EXPECT_TRUE(catcher.GetNextResult()) << message_; 28 EXPECT_TRUE(catcher.GetNextResult()) << message_;
28 } 29 }
29 30
30 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeUninstallURL) { 31 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeUninstallURL) {
32 // Auto-confirm the uninstall dialog.
33 extensions::ManagementUninstallFunction::SetAutoConfirmForTest(true);
31 ASSERT_TRUE(LoadExtension( 34 ASSERT_TRUE(LoadExtension(
32 test_data_dir_.AppendASCII("runtime").AppendASCII("uninstall_url"). 35 test_data_dir_.AppendASCII("runtime").AppendASCII("uninstall_url").
33 AppendASCII("sets_uninstall_url"))); 36 AppendASCII("sets_uninstall_url")));
34 ASSERT_TRUE(RunExtensionTest("runtime/uninstall_url")) << message_; 37 ASSERT_TRUE(RunExtensionTest("runtime/uninstall_url")) << message_;
35 } 38 }
36 39
37 namespace extensions { 40 namespace extensions {
38 41
39 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeGetPlatformInfo) { 42 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeGetPlatformInfo) {
40 scoped_ptr<base::Value> result( 43 scoped_ptr<base::Value> result(
(...skipping 19 matching lines...) Expand all
60 } 63 }
61 64
62 // Tests chrome.runtime.getPackageDirectory with an extension. 65 // Tests chrome.runtime.getPackageDirectory with an extension.
63 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, 66 IN_PROC_BROWSER_TEST_F(ExtensionApiTest,
64 ChromeRuntimeGetPackageDirectoryEntryExtension) { 67 ChromeRuntimeGetPackageDirectoryEntryExtension) {
65 ASSERT_TRUE(RunExtensionTest("runtime/get_package_directory/extension")) 68 ASSERT_TRUE(RunExtensionTest("runtime/get_package_directory/extension"))
66 << message_; 69 << message_;
67 } 70 }
68 71
69 } // namespace extensions 72 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698