chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc - Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix ExtensionManagementApiBrowserTest.LaunchApp Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/runtime/runtime_apitest.cc ('k') | chrome/test/data/extensions/api_test/management/management_policy/allowed.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc b/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

index d2b4757e858c4f311f800229cb26792e945ec8d2..15b5556b27d917b67165a33261a999ad57736850 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc

@@ -9,6 +9,7 @@

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/browser/chrome_notification_types.h"

+#include "chrome/browser/extensions/api/management/management_api.h"

#include "chrome/browser/extensions/api/webstore_private/webstore_private_api.h"

#include "chrome/browser/extensions/extension_apitest.h"

#include "chrome/browser/extensions/extension_function_test_utils.h"

@@ -126,6 +127,8 @@ class ExtensionWebstorePrivateApiTest : public ExtensionApiTest {

// Navigates to |page| and runs the Extension API test there. Any downloads

// of extensions will return the contents of |crx_file|.

bool RunInstallTest(const std::string& page, const std::string& crx_file) {

+ // Auto-confirm the uninstallation dialog.

+ ManagementUninstallFunction::SetAutoConfirmForTest(true);

#if defined(OS_WIN) && !defined(NDEBUG)

// See http://crbug.com/177163 for details.

return true;