chrome/browser/extensions/api/management/management_apitest.cc - Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_apitest.cc

Issue 137793011: Require user confirmation for chrome.management.uninstall except when uninstalling self. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix ExtensionManagementApiBrowserTest.LaunchApp Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/management_api_constants.cc ('k') | chrome/browser/extensions/api/runtime/runtime_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_apitest.cc

diff --git a/chrome/browser/extensions/api/management/management_apitest.cc b/chrome/browser/extensions/api/management/management_apitest.cc

index 3710b3ac3b5b0ca71b9cf39f09bc8ae36c6413b0..facca8feaff565993d9aacb005069dab3381457d 100644

--- a/chrome/browser/extensions/api/management/management_apitest.cc

+++ b/chrome/browser/extensions/api/management/management_apitest.cc

@@ -5,6 +5,7 @@

#include <map>

#include "chrome/browser/chrome_notification_types.h"

+#include "chrome/browser/extensions/api/management/management_api.h"

#include "chrome/browser/extensions/extension_apitest.h"

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_system.h"

@@ -125,6 +126,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, NoPermission) {

IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, MAYBE_Uninstall) {

LoadExtensions();

+ // Confirmation dialog will be shown for uninstallations except for self.

+ extensions::ManagementUninstallFunction::SetAutoConfirmForTest(true);

ASSERT_TRUE(RunExtensionSubtest("management/test", "uninstall.html"));

}

@@ -138,6 +141,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, MAYBE_Uninstall) {

IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest,

MAYBE_ManagementPolicyAllowed) {

LoadExtensions();

+ extensions::ManagementUninstallFunction::SetAutoConfirmForTest(true);

ExtensionService* service = extensions::ExtensionSystem::Get(

browser()->profile())->extension_service();

EXPECT_TRUE(service->GetExtensionById(extension_ids_["enabled_extension"],