tools/gn: Remove code for forward_dependent_configs_from variable.

tools/gn: Remove code for forward_dependent_configs_from variable.

This patch removes the supporting code for this variable, which is
deprecated. Before that all the projects using this variable were
updated and its usage were either updated to 'public_deps' or removed.

BUG=None
R=brettw@chromium.org

Committed: https://crrev.com/b445e7ccd70f09e53a6c93dee8a269d6bf7ee6f0
Cr-Commit-Position: refs/heads/master@{#353144}

[tfarina, 2015-09-30 00:59:45]

Brett, please, take a look.

I'm not sure about some of the removals I did. Please, check it carefully.

Thanks,

[brettw, 2015-09-30 16:47:08]

I'm out today, sorry for the delay.

[tfarina, 2015-10-02 22:04:35]

Ping?

[brettw, 2015-10-05 18:06:06]

Sorry! I accidentally left this marked read last time and forgot about it :-/

There are a few things I think you missed. Make sure that there are no
"forward_dependent_configs" things left (the old code didn't realiably use the
"_from" suffix.

https://codereview.chromium.org/1375023003/diff/1/tools/gn/builder.cc
File tools/gn/builder.cc (left):

https://codereview.chromium.org/1375023003/diff/1/tools/gn/builder.cc#oldcode484
tools/gn/builder.cc:484: target->forward_dependent_configs();
Is this patch trying to remove all the code for forward_dependent_configs? In
that case, I think this whole Builder::ResolveForwardDependentConfigs function,
and the Target::forward_dependent_configs stuff can all be deleted.

https://codereview.chromium.org/1375023003/diff/1/tools/gn/target_unittest.cc
File tools/gn/target_unittest.cc (right):

https://codereview.chromium.org/1375023003/diff/1/tools/gn/target_unittest.cc...
tools/gn/target_unittest.cc:79: // forward_dependent_configs.
I think you remove the forward_dependent_configs reference here.

https://codereview.chromium.org/1375023003/diff/1/tools/gn/target_unittest.cc...
tools/gn/target_unittest.cc:127:
b_fwd.forward_dependent_configs().push_back(LabelTargetPair(&c));
Delete this. I'm not sure if any expectations below need to be updated.

[tfarina, 2015-10-06 03:28:50]

https://codereview.chromium.org/1375023003/diff/1/tools/gn/builder.cc
File tools/gn/builder.cc (left):

https://codereview.chromium.org/1375023003/diff/1/tools/gn/builder.cc#oldcode484
tools/gn/builder.cc:484: target->forward_dependent_configs();
On 2015/10/05 18:06:06, brettw wrote:
> Is this patch trying to remove all the code for forward_dependent_configs? In
> that case, I think this whole Builder::ResolveForwardDependentConfigs
function,
> and the Target::forward_dependent_configs stuff can all be deleted.

Done.

https://codereview.chromium.org/1375023003/diff/1/tools/gn/target_unittest.cc
File tools/gn/target_unittest.cc (right):

https://codereview.chromium.org/1375023003/diff/1/tools/gn/target_unittest.cc...
tools/gn/target_unittest.cc:79: // forward_dependent_configs.
On 2015/10/05 18:06:06, brettw wrote:
> I think you remove the forward_dependent_configs reference here.

Done.

https://codereview.chromium.org/1375023003/diff/1/tools/gn/target_unittest.cc...
tools/gn/target_unittest.cc:127:
b_fwd.forward_dependent_configs().push_back(LabelTargetPair(&c));
On 2015/10/05 18:06:06, brettw wrote:
> Delete this. I'm not sure if any expectations below need to be updated.

Done.

https://codereview.chromium.org/1375023003/diff/20001/tools/gn/target_unittes...
File tools/gn/target_unittest.cc (left):

https://codereview.chromium.org/1375023003/diff/20001/tools/gn/target_unittes...
tools/gn/target_unittest.cc:127:
b_fwd.forward_dependent_configs().push_back(LabelTargetPair(&c));
I'm not sure about these unit tests changes. Please, check.

[tfarina, 2015-10-06 23:10:53]

Brett, ping? Could you take another look?

[brettw, 2015-10-08 20:50:49]

Sorry, my schedule has been crazy lately.

LGTM

[tfarina, 2015-10-08 21:18:27]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-10-08 21:19:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1375023003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1375023003/20001

[commit-bot: I haz the power, 2015-10-08 21:39:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-08 21:39:48]

Patchset 2 (id:??) landed as
https://crrev.com/b445e7ccd70f09e53a6c93dee8a269d6bf7ee6f0
Cr-Commit-Position: refs/heads/master@{#353144}