Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: tools/gn/builder.h

Issue 1375023003: tools/gn: Remove code for forward_dependent_configs_from variable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forward_dependent_configs Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/gn/builder.cc » ('j') | tools/gn/target_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_BUILDER_H_ 5 #ifndef TOOLS_GN_BUILDER_H_
6 #define TOOLS_GN_BUILDER_H_ 6 #define TOOLS_GN_BUILDER_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/containers/hash_tables.h" 9 #include "base/containers/hash_tables.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 111
112 // This takes a BuilderRecord with resolved depdencies, and fills in the 112 // This takes a BuilderRecord with resolved depdencies, and fills in the
113 // target's Label*Vectors with the resolved pointers. 113 // target's Label*Vectors with the resolved pointers.
114 bool ResolveItem(BuilderRecord* record, Err* err); 114 bool ResolveItem(BuilderRecord* record, Err* err);
115 115
116 // Fills in the pointers in the given vector based on the labels. We assume 116 // Fills in the pointers in the given vector based on the labels. We assume
117 // that everything should be resolved by this point, so will return an error 117 // that everything should be resolved by this point, so will return an error
118 // if anything isn't found or if the type doesn't match. 118 // if anything isn't found or if the type doesn't match.
119 bool ResolveDeps(LabelTargetVector* deps, Err* err); 119 bool ResolveDeps(LabelTargetVector* deps, Err* err);
120 bool ResolveConfigs(UniqueVector<LabelConfigPair>* configs, Err* err); 120 bool ResolveConfigs(UniqueVector<LabelConfigPair>* configs, Err* err);
121 bool ResolveForwardDependentConfigs(Target* target, Err* err);
122 bool ResolveToolchain(Target* target, Err* err); 121 bool ResolveToolchain(Target* target, Err* err);
123 122
124 // Given a list of unresolved records, tries to find any circular 123 // Given a list of unresolved records, tries to find any circular
125 // dependencies and returns the string describing the problem. If no circular 124 // dependencies and returns the string describing the problem. If no circular
126 // deps were found, returns the empty string. 125 // deps were found, returns the empty string.
127 std::string CheckForCircularDependencies( 126 std::string CheckForCircularDependencies(
128 const std::vector<const BuilderRecord*>& bad_records) const; 127 const std::vector<const BuilderRecord*>& bad_records) const;
129 128
130 // Non owning pointer. 129 // Non owning pointer.
131 Loader* loader_; 130 Loader* loader_;
132 131
133 // Owning pointers. 132 // Owning pointers.
134 typedef base::hash_map<Label, BuilderRecord*> RecordMap; 133 typedef base::hash_map<Label, BuilderRecord*> RecordMap;
135 RecordMap records_; 134 RecordMap records_;
136 135
137 ResolvedCallback resolved_callback_; 136 ResolvedCallback resolved_callback_;
138 137
139 DISALLOW_COPY_AND_ASSIGN(Builder); 138 DISALLOW_COPY_AND_ASSIGN(Builder);
140 }; 139 };
141 140
142 #endif // TOOLS_GN_BUILDER_H_ 141 #endif // TOOLS_GN_BUILDER_H_
OLDNEW
« no previous file with comments | « no previous file | tools/gn/builder.cc » ('j') | tools/gn/target_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698