tools/gn: Remove code for forward_dependent_configs_from variable.

tools/gn/target_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "tools/gn/build_settings.h"
 #include "tools/gn/config.h"
 #include "tools/gn/scheduler.h"
 #include "tools/gn/settings.h"
 #include "tools/gn/target.h"
@@ skipping 57 matching lines @@
   EXPECT_EQ(libdir, shared.all_lib_dirs()[1]);
 
   // Executable target shouldn't get either by depending on shared.
   TestTarget exec(setup, "//foo:exec", Target::EXECUTABLE);
   exec.private_deps().push_back(LabelTargetPair(&shared));
   ASSERT_TRUE(exec.OnResolved(&err));
   EXPECT_EQ(0u, exec.all_libs().size());
   EXPECT_EQ(0u, exec.all_lib_dirs().size());
 }
 
-// Test all_dependent_configs, public_config inheritance, and
-// forward_dependent_configs_from
+// Test all_dependent_configs and public_config inheritance.
 TEST(Target, DependentConfigs) {
   TestWithScope setup;
   Err err;
 
   // Set up a dependency chain of a -> b -> c
   TestTarget a(setup, "//foo:a", Target::EXECUTABLE);
   TestTarget b(setup, "//foo:b", Target::STATIC_LIBRARY);
   TestTarget c(setup, "//foo:c", Target::STATIC_LIBRARY);
   a.private_deps().push_back(LabelTargetPair(&b));
   b.private_deps().push_back(LabelTargetPair(&c));
@@ skipping 27 matching lines @@
   // A should have just gotten the "all" dependent config from C.
   ASSERT_EQ(1u, a.configs().size());
   EXPECT_EQ(&all, a.configs()[0].ptr);
   EXPECT_EQ(&all, a.all_dependent_configs()[0].ptr);
 
   // Making an an alternate A and B with B forwarding the direct dependents.
   TestTarget a_fwd(setup, "//foo:a_fwd", Target::EXECUTABLE);
   TestTarget b_fwd(setup, "//foo:b_fwd", Target::STATIC_LIBRARY);
   a_fwd.private_deps().push_back(LabelTargetPair(&b_fwd));
   b_fwd.private_deps().push_back(LabelTargetPair(&c));
-  b_fwd.forward_dependent_configs().push_back(LabelTargetPair(&c));

[tfarina, 2015/10/06 03:28:50]

I'm not sure about these unit tests changes. Please, check.

 
   ASSERT_TRUE(b_fwd.OnResolved(&err));
   ASSERT_TRUE(a_fwd.OnResolved(&err));
 
   // A_fwd should now have both configs.
-  ASSERT_EQ(2u, a_fwd.configs().size());
+  ASSERT_EQ(1u, a_fwd.configs().size());
   EXPECT_EQ(&all, a_fwd.configs()[0].ptr);
-  EXPECT_EQ(&direct, a_fwd.configs()[1].ptr);
   ASSERT_EQ(1u, a_fwd.all_dependent_configs().size());
   EXPECT_EQ(&all, a_fwd.all_dependent_configs()[0].ptr);
 }
 
 TEST(Target, InheritLibs) {
   TestWithScope setup;
   Err err;
 
   // Create a dependency chain:
   //   A (executable) -> B (shared lib) -> C (static lib) -> D (source set)
@@ skipping 234 matching lines @@
   // to the current target.
   TestTarget dep_on_pub(setup, "//a:dop", Target::SOURCE_SET);
   dep_on_pub.private_deps().push_back(LabelTargetPair(&pub));
   ASSERT_TRUE(dep_on_pub.OnResolved(&err));
   ASSERT_EQ(1u, dep_on_pub.configs().size());
   EXPECT_EQ(&pub_config, dep_on_pub.configs()[0].ptr);
 
   // This target has a private dependency on dest for forwards configs.
   TestTarget forward(setup, "//a:f", Target::SOURCE_SET);
   forward.private_deps().push_back(LabelTargetPair(&dest));
-  forward.forward_dependent_configs().push_back(LabelTargetPair(&dest));
   ASSERT_TRUE(forward.OnResolved(&err));
-
-  // Depending on the forward target should apply the config.
-  TestTarget dep_on_forward(setup, "//a:dof", Target::SOURCE_SET);
-  dep_on_forward.private_deps().push_back(LabelTargetPair(&forward));
-  ASSERT_TRUE(dep_on_forward.OnResolved(&err));
-  ASSERT_EQ(1u, dep_on_forward.configs().size());
-  EXPECT_EQ(&pub_config, dep_on_forward.configs()[0].ptr);
 }
 
 // Tests that different link/depend outputs work for solink tools.
 TEST(Target, LinkAndDepOutputs) {
   TestWithScope setup;
   Err err;
 
   Toolchain toolchain(setup.settings(), Label(SourceDir("//tc/"), "tc"));
 
   scoped_ptr<Tool> solink_tool(new Tool());
@@ skipping 203 matching lines @@
       "\n"
       "From //foo:bar\n"
       "  header: pch.h\n"
       "  source: //pcs.cc\n"
       "\n"
       "From //foo:c2\n"
       "  header: pch2.h\n"
       "  source: //pcs2.cc",
       err.help_text());
 }