Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: tools/gn/target.h

Issue 1375023003: tools/gn: Remove code for forward_dependent_configs_from variable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: forward_dependent_configs Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/target.h
diff --git a/tools/gn/target.h b/tools/gn/target.h
index a9832416f1ba223abb01c4f38bc344f44bd29d48..fc752acece8896611b2f12047d723e69e3615bad 100644
--- a/tools/gn/target.h
+++ b/tools/gn/target.h
@@ -174,15 +174,6 @@ class Target : public Item {
return public_configs_;
}
- // A list of a subset of deps where we'll re-export public_configs as
- // public_configs of this target.
- const UniqueVector<LabelTargetPair>& forward_dependent_configs() const {
- return forward_dependent_configs_;
- }
- UniqueVector<LabelTargetPair>& forward_dependent_configs() {
- return forward_dependent_configs_;
- }
-
// Dependencies that can include files from this target.
const std::set<Label>& allow_circular_includes_from() const {
return allow_circular_includes_from_;
@@ -260,8 +251,8 @@ class Target : public Item {
// These each pull specific things from dependencies to this one when all
// deps have been resolved.
- void PullForwardedDependentConfigs();
- void PullForwardedDependentConfigsFrom(const Target* from);
+ void PullPublicConfigs();
+ void PullPublicConfigsFrom(const Target* from);
void PullRecursiveHardDeps();
// Fills the link and dependency output files when a target is resolved.
@@ -298,7 +289,6 @@ class Target : public Item {
UniqueVector<LabelConfigPair> configs_;
UniqueVector<LabelConfigPair> all_dependent_configs_;
UniqueVector<LabelConfigPair> public_configs_;
- UniqueVector<LabelTargetPair> forward_dependent_configs_;
std::set<Label> allow_circular_includes_from_;
« no previous file with comments | « tools/gn/misc/vim/syntax/gn.vim ('k') | tools/gn/target.cc » ('j') | tools/gn/target_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698