Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: third_party/WebKit/Source/core/css/CSSImageValue.h

Issue 1373753002: Change CSSToStyleMap functions to take const CSSValue&s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSImageValue.h
diff --git a/third_party/WebKit/Source/core/css/CSSImageValue.h b/third_party/WebKit/Source/core/css/CSSImageValue.h
index f3f827cf8dfb91c62cf5c422bb24d2d82fc02170..b5e915a35771acb61d67070621b1472e338c6f68 100644
--- a/third_party/WebKit/Source/core/css/CSSImageValue.h
+++ b/third_party/WebKit/Source/core/css/CSSImageValue.h
@@ -51,16 +51,16 @@ public:
~CSSImageValue();
bool isCachePending() const { return m_isCachePending; }
- StyleFetchedImage* cachedImage() { ASSERT(!isCachePending()); return m_cachedImage.get(); }
- StyleFetchedImage* cacheImage(Document*, const ResourceLoaderOptions&);
- StyleFetchedImage* cacheImage(Document* document) { return cacheImage(document, ResourceFetcher::defaultResourceOptions()); }
+ StyleFetchedImage* cachedImage() const { ASSERT(!isCachePending()); return m_cachedImage.get(); }
+ StyleFetchedImage* cacheImage(Document*, const ResourceLoaderOptions&) const;
+ StyleFetchedImage* cacheImage(Document* document) const { return cacheImage(document, ResourceFetcher::defaultResourceOptions()); }
- const String& url() { return m_absoluteURL; }
+ const String& url() const { return m_absoluteURL; }
void setReferrer(const Referrer& referrer) { m_referrer = referrer; }
const Referrer& referrer() const { return m_referrer; }
- void reResolveURL(const Document&);
+ void reResolveURL(const Document&) const;
String customCSSText() const;
@@ -70,7 +70,7 @@ public:
bool knownToBeOpaque(const LayoutObject*) const;
- PassRefPtrWillBeRawPtr<CSSImageValue> valueWithURLMadeAbsolute()
+ PassRefPtrWillBeRawPtr<CSSImageValue> valueWithURLMadeAbsolute() const
{
return create(KURL(ParsedURLString, m_absoluteURL), m_cachedImage.get());
}
@@ -78,16 +78,16 @@ public:
void setInitiator(const AtomicString& name) { m_initiatorName = name; }
DECLARE_TRACE_AFTER_DISPATCH();
- void restoreCachedResourceIfNeeded(Document&);
+ void restoreCachedResourceIfNeeded(Document&) const;
private:
CSSImageValue(const AtomicString& rawValue, const KURL&, StyleFetchedImage*);
AtomicString m_relativeURL;
- AtomicString m_absoluteURL;
+ mutable AtomicString m_absoluteURL;
Referrer m_referrer;
- bool m_isCachePending;
- RefPtrWillBeMember<StyleFetchedImage> m_cachedImage;
+ mutable bool m_isCachePending;
+ mutable RefPtrWillBeMember<StyleFetchedImage> m_cachedImage;
AtomicString m_initiatorName;
};

Powered by Google App Engine
This is Rietveld 408576698