third_party/WebKit/Source/core/css/CSSImageValue.cpp - Issue 1373753002: Change CSSToStyleMap functions to take const CSSValue&s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSImageValue.cpp

Issue 1373753002: Change CSSToStyleMap functions to take const CSSValue&s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSImageValue.h ('k') | third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp » ('j') | third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSImageValue.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSImageValue.cpp b/third_party/WebKit/Source/core/css/CSSImageValue.cpp

index 01455f06f1c8ada61edca3a1fbc7169f6bb63f8f..12a1915ba9d70c06b08ba20b9c4462c4d17b9a30 100644

--- a/third_party/WebKit/Source/core/css/CSSImageValue.cpp

+++ b/third_party/WebKit/Source/core/css/CSSImageValue.cpp

@@ -46,7 +46,7 @@ CSSImageValue::~CSSImageValue()

{

}

-StyleFetchedImage* CSSImageValue::cacheImage(Document* document, const ResourceLoaderOptions& options)

+StyleFetchedImage* CSSImageValue::cacheImage(Document* document, const ResourceLoaderOptions& options) const

{

ASSERT(document);

@@ -66,7 +66,7 @@ StyleFetchedImage* CSSImageValue::cacheImage(Document* document, const ResourceL

return m_cachedImage.get();

}

-void CSSImageValue::restoreCachedResourceIfNeeded(Document& document)

+void CSSImageValue::restoreCachedResourceIfNeeded(Document& document) const

{

if (m_isCachePending || !m_cachedImage || !document.fetcher())

return;

@@ -113,7 +113,7 @@ DEFINE_TRACE_AFTER_DISPATCH(CSSImageValue)

CSSValue::traceAfterDispatch(visitor);

}

-void CSSImageValue::reResolveURL(const Document& document)

+void CSSImageValue::reResolveURL(const Document& document) const

{

KURL url = document.completeURL(m_relativeURL);

AtomicString urlString(url.string());