third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp - Issue 1373753002: Change CSSToStyleMap functions to take const CSSValue&s

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 1373753002: Change CSSToStyleMap functions to take const CSSValue&s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp ('k') | third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

index 3a063cb536363d4270542dee769b14eab99a2ed5..1f470af9137206747d26b08b89ce3af9a1ca379d 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp

@@ -79,7 +79,8 @@ PassRefPtr<StyleReflection> StyleBuilderConverter::convertBoxReflect(StyleResolv

reflection->setOffset(reflectValue->offset()->convertToLength(state.cssToLengthConversionData()));

NinePieceImage mask;

Timothy Loh 2015/10/06 02:50:46 the if check you're adding should start from here

sashab 2015/10/07 01:37:58 Are you sure? Surely we want mask.setMaskDefaults(

Timothy Loh 2015/10/07 02:27:00 We don't need to setMask at all in this case thoug

sashab 2015/10/07 02:33:35 Oh I see, good point. Fixed up now.

mask.setMaskDefaults();

- CSSToStyleMap::mapNinePieceImage(state, CSSPropertyWebkitBoxReflect, reflectValue->mask(), mask);

+ if (reflectValue->mask())

+ CSSToStyleMap::mapNinePieceImage(state, CSSPropertyWebkitBoxReflect, *reflectValue->mask(), mask);

reflection->setMask(mask);

return reflection.release();