third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp - Issue 1373753002: Change CSSToStyleMap functions to take const CSSValue&s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

Issue 1373753002: Change CSSToStyleMap functions to take const CSSValue&s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp ('k') | third_party/WebKit/Source/core/css/CSSImageValue.h » ('j') | third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

index b38de39e7ebba95fce91d9d9fcb4235e929f60bc..4a6477e5338e92a56eb8405d9fdc3456e16201f7 100644

--- a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

@@ -94,7 +94,7 @@ static StringKeyframeEffectModel* createKeyframeEffectModel(StyleResolver* resol

if (value->isInheritedValue() && parentStyle->animations()) {

timingFunction = parentStyle->animations()->timingFunctionList()[0];

} else if (value->isValueList()) {

- timingFunction = CSSToStyleMap::mapAnimationTimingFunction(toCSSValueList(value)->item(0));

+ timingFunction = CSSToStyleMap::mapAnimationTimingFunction(*toCSSValueList(value)->item(0));

} else {

ASSERT(value->isCSSWideKeyword());

timingFunction = CSSTimingData::initialTimingFunction();