third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp - Issue 1373753002: Change CSSToStyleMap functions to take const CSSValue&s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp

Issue 1373753002: Change CSSToStyleMap functions to take const CSSValue&s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl ('k') | third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp » ('j') | third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp

diff --git a/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp b/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp

index 22687ac7a71bcc065a6f17eef7ddbc25d58b7a55..892df1e7018a7b7e506faebd02f620cddaa1bea5 100644

--- a/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp

+++ b/third_party/WebKit/Source/core/animation/AnimationInputHelpers.cpp

@@ -41,7 +41,7 @@ PassRefPtr<TimingFunction> AnimationInputHelpers::parseTimingFunction(const Stri

CSSValueList* valueList = toCSSValueList(value.get());

if (valueList->length() > 1)

return nullptr;

- return CSSToStyleMap::mapAnimationTimingFunction(valueList->item(0), true);

+ return CSSToStyleMap::mapAnimationTimingFunction(*valueList->item(0), true);

}

} // namespace blink