Omnibox UMA: Record How People Enter Keyword Mode

Omnibox UMA: Record How People Enter Keyword Mode

BUG=219218
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194035

[Mark P, 2013-04-05 23:04:15]

Peter,

What do you think about this design?

thanks,
mark

[Peter Kasting, 2013-04-05 23:18:33]

You also should probably collect stats on the
CreatedKeywordSearchByInsertingSpaceInMiddle() case.  Note that that doesn't
call AcceptKeyword() directly, we'll just switch to keyword mode in the process
of calling UpdatePopup().

I don't know whether it's always true that if
CreatedKeywordSearchByInsertingSpaceInMiddle() returns true, the subsequent
UpdatePopup() call will definitely switch to keyword mode.

https://codereview.chromium.org/13730016/diff/2001/chrome/browser/ui/omnibox/...
File chrome/browser/ui/omnibox/omnibox_edit_model.cc (right):

https://codereview.chromium.org/13730016/diff/2001/chrome/browser/ui/omnibox/...
chrome/browser/ui/omnibox/omnibox_edit_model.cc:750: 3);
Why not just UMA_HISTOGRAM_BOOLEAN?

[Mark P, 2013-04-09 18:33:36]

On 2013/04/05 23:18:33, Peter Kasting wrote:
> You also should probably collect stats on the
> CreatedKeywordSearchByInsertingSpaceInMiddle() case.  Note that that doesn't
> call AcceptKeyword() directly, we'll just switch to keyword mode in the
process
> of calling UpdatePopup().

I rewrite this changelist to be able to deal with
CreatedKeywordSearchByInsertingSpaceInMiddle().  Please take a look.

Are there other ways you know of to enter keyword mode besides those I'm
recording?  Or at least similar ways to enter keyword mode that go through
different code paths and hence don't get recorded?

> I don't know whether it's always true that if
> CreatedKeywordSearchByInsertingSpaceInMiddle() returns true, the subsequent
> UpdatePopup() call will definitely switch to keyword mode.

Looking at the code, I think this is true.  I'm sure it's "true enough" for our
statistics to be useful.

--mark

>
https://codereview.chromium.org/13730016/diff/2001/chrome/browser/ui/omnibox/...
> File chrome/browser/ui/omnibox/omnibox_edit_model.cc (right):
> 
>
https://codereview.chromium.org/13730016/diff/2001/chrome/browser/ui/omnibox/...
> chrome/browser/ui/omnibox/omnibox_edit_model.cc:750: 3);
> Why not just UMA_HISTOGRAM_BOOLEAN?

[Peter Kasting, 2013-04-11 21:57:46]

LGTM.  I'm not aware of any other ways to enter keyword mode at the moment.

https://codereview.chromium.org/13730016/diff/5001/chrome/browser/ui/omnibox/...
File chrome/browser/ui/omnibox/omnibox_edit_model.h (right):

https://codereview.chromium.org/13730016/diff/5001/chrome/browser/ui/omnibox/...
chrome/browser/ui/omnibox/omnibox_edit_model.h:65:
ENTERED_KEYWORD_MODE_VIA_SPACE_AT_END = 0,
Tiny nit, but it seems like swapping these first two might be nicer (in grouping
the space-related items and also putting them in descending order of usage)

[Mark P, 2013-04-11 22:03:04]

https://codereview.chromium.org/13730016/diff/5001/chrome/browser/ui/omnibox/...
File chrome/browser/ui/omnibox/omnibox_edit_model.h (right):

https://codereview.chromium.org/13730016/diff/5001/chrome/browser/ui/omnibox/...
chrome/browser/ui/omnibox/omnibox_edit_model.h:65:
ENTERED_KEYWORD_MODE_VIA_SPACE_AT_END = 0,
On 2013/04/11 21:57:46, Peter Kasting wrote:
> Tiny nit, but it seems like swapping these first two might be nicer (in
grouping
> the space-related items and also putting them in descending order of usage)

Done.

[Mark P, 2013-04-11 22:05:19]

Evan,

Can I get an OWNERS rubberstamp on this?

thanks,
mark

[Evan Stade, 2013-04-12 17:07:45]

gtk lgtm

[Mark P, 2013-04-12 18:06:10]

Let's see what other owners I'm missing...

[commit-bot: I haz the power, 2013-04-12 18:06:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/13730016/10001

[commit-bot: I haz the power, 2013-04-12 19:12:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpearson@chromium.org/13730016/26001

[commit-bot: I haz the power, 2013-04-12 23:00:06]

Change committed as 194035