chrome/browser/ui/views/omnibox/omnibox_view_win.cc - Issue 13730016: Omnibox UMA: Record How People Enter Keyword Mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_win.cc

Issue 13730016: Omnibox UMA: Record How People Enter Keyword Mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix views Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_view_win.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_win.cc b/chrome/browser/ui/views/omnibox/omnibox_view_win.cc

index 03f188809fd98ee6b63723318d231f38c9d661c8..ba6fc04647597bac2a2665c513b761632ee47138 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_win.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_win.cc

@@ -2307,7 +2307,7 @@ bool OmniboxViewWin::OnKeyDownOnlyWritable(TCHAR key,

if (model()->is_keyword_hint() && !shift_pressed) {

// Accept the keyword.

ScopedFreeze freeze(this, GetTextObjectModel());

- model()->AcceptKeyword();

+ model()->AcceptKeyword(ENTERED_KEYWORD_MODE_VIA_TAB);

} else if (shift_pressed &&

model()->popup_model()->selected_line_state() ==

OmniboxPopupModel::KEYWORD) {

« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views.cc ('k') | no next file » | no next file with comments »