chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc - Issue 13730016: Omnibox UMA: Record How People Enter Keyword Mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

Issue 13730016: Omnibox UMA: Record How People Enter Keyword Mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix views Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

diff --git a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

index 2cce44cb138b26d1d94bc9070e8272aab4ac79b7..2bf2306bef27973301cb74b0ba12aa10ad5379dd 100644

--- a/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

+++ b/chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

@@ -1537,7 +1537,7 @@ void OmniboxViewGtk::HandleViewMoveFocus(GtkWidget* widget,

// Trigger Tab to search behavior only when Tab key is pressed.

if (model()->is_keyword_hint() && !shift_was_pressed_) {

- handled = model()->AcceptKeyword();

+ handled = model()->AcceptKeyword(ENTERED_KEYWORD_MODE_VIA_TAB);

} else if (model()->popup_model()->IsOpen()) {

if (shift_was_pressed_ &&

model()->popup_model()->selected_line_state() ==