chrome/browser/ui/views/omnibox/omnibox_view_views.cc - Issue 13730016: Omnibox UMA: Record How People Enter Keyword Mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 13730016: Omnibox UMA: Record How People Enter Keyword Mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix views Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

index 1c4e18498de7f3d43064829285e9080490d32e2c..503adacd0c5ccf953c520e91753f87e4a8c31ac1 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

@@ -309,7 +309,7 @@ bool OmniboxViewViews::SkipDefaultKeyEventProcessing(

// This must run before acclerator handling invokes a focus change on tab.

if (views::FocusManager::IsTabTraversalKeyEvent(event)) {

if (model()->is_keyword_hint() && !event.IsShiftDown()) {

- model()->AcceptKeyword();

+ model()->AcceptKeyword(ENTERED_KEYWORD_MODE_VIA_TAB);

return true;

}

if (model()->popup_model()->IsOpen()) {