build/android/devil/android/device_utils.py - Issue 1372873003: DeviceUtils: Fix a couple of corner-cases when wrapping commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/devil/android/device_utils.py

Issue 1372873003: DeviceUtils: Fix a couple of corner-cases when wrapping commands. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@device-utils-concurrent-md5

Patch Set: rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/devil/android/device_utils.py

diff --git a/build/android/devil/android/device_utils.py b/build/android/devil/android/device_utils.py

index e01f462ea86a0d640b19e42a93217cd6080ebc12..432677f91917734e31f48c9392339ce3c30de90d 100644

--- a/build/android/devil/android/device_utils.py

+++ b/build/android/devil/android/device_utils.py

@@ -752,7 +752,7 @@ class DeviceUtils(object):

def handle_large_output(cmd, large_output_mode):

if large_output_mode:

with device_temp_file.DeviceTempFile(self.adb) as large_output_file:

- cmd = '%s > %s' % (cmd, large_output_file.name)

+ cmd = '( %s )>%s' % (cmd, large_output_file.name)

logging.debug('Large output mode enabled. Will write output to '

'device and read results from file.')

handle_large_command(cmd)

« no previous file with comments | « no previous file | build/android/devil/android/device_utils_test.py » ('j') | no next file with comments »