build/android/devil/android/sdk/adb_wrapper.py - Issue 1372873003: DeviceUtils: Fix a couple of corner-cases when wrapping commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/devil/android/sdk/adb_wrapper.py

Issue 1372873003: DeviceUtils: Fix a couple of corner-cases when wrapping commands. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@device-utils-concurrent-md5

Patch Set: rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/devil/android/sdk/adb_wrapper.py

diff --git a/build/android/devil/android/sdk/adb_wrapper.py b/build/android/devil/android/sdk/adb_wrapper.py

index bf68b569170b37f652a401d2803dff284aafa394..77fbdc1128b2af34377bfb5210af11074cc82db6 100644

--- a/build/android/devil/android/sdk/adb_wrapper.py

+++ b/build/android/devil/android/sdk/adb_wrapper.py

@@ -267,7 +267,7 @@ class AdbWrapper(object):

if expect_status is None:

args = ['shell', command]

else:

- args = ['shell', '(%s);echo %%$?' % command.rstrip()]

+ args = ['shell', '( %s );echo %%$?' % command.rstrip()]

output = self._RunDeviceAdbCmd(args, timeout, retries, check_error=False)

if expect_status is not None:

output_end = output.rfind('%')

« no previous file with comments | « build/android/devil/android/device_utils_test.py ('k') | no next file » | no next file with comments »