Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1372133003: Revert of chromium_tests: raise infra failure when no compile targets are specified (patchset #1 id: (Closed)

Created:
5 years, 2 months ago by Nico
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
http://src.chromium.org/chrome/trunk/tools/build/
Project:
build
Visibility:
Public.

Description

Revert of chromium_tests: raise infra failure when no compile targets are specified (patchset #1 id:1 of https://codereview.chromium.org/1376453002/ ) Reason for revert: This is not a valid assumption, e.g. the clang bots all use the empty compile target as build target and were all broken with this. (As discussed previously, even!) Original issue's description: > chromium_tests: raise infra failure when no compile targets are specified > > This relies on default compile targets either on the recipe side or ninja, > but breaks badly with e.g. analyze. We're trying to make as much of bot > config explicit as possible. > > BUG=536186 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296903 TBR=tandrii@chromium.org,sergiyb@chromium.org,hans@chromium.org,phajdan.jr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=536186 Review URL: https://codereview.chromium.org/1377453003/ TBR=phajdan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296916

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3441 lines, -341 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 chunk +0 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux.json View 1 chunk +29 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_10.json View 1 chunk +31 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Win_10.json View 1 chunk +15 lines, -12 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTAndroidASan.json View 1 chunk +68 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux.json View 1 chunk +134 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinuxASan.json View 1 chunk +134 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTLinux__dbg_.json View 1 chunk +85 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac.json View 1 chunk +134 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json View 1 chunk +135 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac__dbg_.json View 1 chunk +85 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json View 1 chunk +159 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64.json View 1 chunk +159 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dbg_.json View 1 chunk +156 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dll_.json View 1 chunk +156 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dbg_.json View 1 chunk +156 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin_dll_.json View 1 chunk +156 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTiOS.json View 1 chunk +13 lines, -12 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang.json View 1 chunk +99 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64.json View 1 chunk +99 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dbg_.json View 1 chunk +60 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dll_.json View 1 chunk +96 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD.json View 1 chunk +102 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangLLD64.json View 1 chunk +102 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_dbg_.json View 1 chunk +96 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_shared_.json View 1 chunk +96 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLD64dbg.json View 1 chunk +102 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLDdbg.json View 1 chunk +102 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Mac_OpenSSL.json View 1 chunk +31 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_GN.json View 1 chunk +16 lines, -12 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_GN__dbg_.json View 1 chunk +16 lines, -12 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_linux_Android_x86_Builder__dbg_.json View 1 chunk +34 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Builder.json View 1 chunk +127 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_arm64_Builder.json View 1 chunk +51 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_android_oilpan_builder.json View 1 chunk +49 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Chromium_ASAN___debug.json View 1 chunk +111 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Chromium_ASAN__symbolized_.json View 1 chunk +111 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Linux_ASAN_Builder.json View 1 chunk +62 lines, -8 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Linux_Debug_Builder.json View 1 chunk +46 lines, -10 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Linux_Snapshot_Builder.json View 1 chunk +28 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372133003/20001
5 years, 2 months ago (2015-09-28 18:55:44 UTC) #2
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 18:56:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296916

Powered by Google App Engine
This is Rietveld 408576698