Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Chromium_ASAN__symbolized_.json

Issue 1372133003: Revert of chromium_tests: raise infra failure when no compile targets are specified (patchset #1 id: (Closed) Base URL: http://src.chromium.org/chrome/trunk/tools/build/
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Chromium_ASAN__symbolized_.json
===================================================================
--- scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Chromium_ASAN__symbolized_.json (revision 296915)
+++ scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Chromium_ASAN__symbolized_.json (working copy)
@@ -120,22 +120,125 @@
"name": "cleanup_temp"
},
{
+ "allow_subannotations": true,
"cmd": [
"python",
"-u",
- "import sys; sys.exit(1)"
+ "[BUILD]/scripts/slave/clang_revision.py",
+ "--src-dir",
+ "[SLAVE_BUILD]/src",
+ "--output-json",
+ "/path/to/tmp/json"
],
"cwd": "[SLAVE_BUILD]",
- "name": "compile",
+ "name": "clang_revision",
"~followup_annotations": [
- "step returned non-zero exit code: 1",
- "@@@STEP_TEXT@Misconfigured bot: no compile targets@@@",
- "@@@STEP_FAILURE@@@"
+ "@@@STEP_LOG_LINE@json.output@{@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"clang_revision\": \"123456-7\"@@@",
+ "@@@STEP_LOG_LINE@json.output@}@@@",
+ "@@@STEP_LOG_END@json.output@@@"
]
},
{
- "name": "$final_result",
- "reason": "Step('compile') failed with return_code 1",
- "status_code": 1
+ "cmd": [
+ "python",
+ "-u",
+ "[BUILD]/scripts/slave/compile.py",
+ "--target",
+ "Release",
+ "--src-dir",
+ "[SLAVE_BUILD]/src",
+ "--build-tool",
+ "ninja",
+ "--compiler",
+ "goma-clang",
+ "--goma-dir",
+ "[BUILD]/goma",
+ "--clobber",
+ "--",
+ "chromium_builder_asan"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "compile"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "\nimport json, os, sys\nif os.path.exists(sys.argv[1]) and os.path.isdir(sys.argv[1]):\n with open(sys.argv[2], 'w') as f:\n json.dump(os.listdir(sys.argv[1]), f)\n",
+ "[SLAVE_BUILD]/src/out/Release",
+ "/path/to/tmp/json"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "listdir build_dir",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@json.output@[@@@",
+ "@@@STEP_LOG_LINE@json.output@ \"file 1\", @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"file 2\"@@@",
+ "@@@STEP_LOG_LINE@json.output@]@@@",
+ "@@@STEP_LOG_END@json.output@@@",
+ "@@@STEP_LOG_LINE@python.inline@@@@",
+ "@@@STEP_LOG_LINE@python.inline@import json, os, sys@@@",
+ "@@@STEP_LOG_LINE@python.inline@if os.path.exists(sys.argv[1]) and os.path.isdir(sys.argv[1]):@@@",
+ "@@@STEP_LOG_LINE@python.inline@ with open(sys.argv[2], 'w') as f:@@@",
+ "@@@STEP_LOG_LINE@python.inline@ json.dump(os.listdir(sys.argv[1]), f)@@@",
+ "@@@STEP_LOG_END@python.inline@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "RECIPE_MODULE[archive]/resources/zip_archive.py",
+ "[TMP_BASE]/chrome_staging_tmp_1",
+ "asan-symbolized-linux-release-v8-component-43426",
+ "[\"file 1\", \"file 2\"]",
+ "[SLAVE_BUILD]/src/out/Release"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "zipping"
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "[DEPOT_TOOLS]/gsutil.py",
+ "--force-version",
+ "3.25",
+ "--",
+ "-h",
+ "x-goog-meta-Cr-Commit-Position:refs/heads/master@{#43426}",
+ "-h",
+ "x-goog-meta-Cr-Commit-Position-Number:43426",
+ "-h",
+ "x-goog-meta-Cr-Git-Commit:801ada225ddc271c132c3a35f03975671d43e399",
+ "cp",
+ "-a",
+ "public-read",
+ "[TMP_BASE]/chrome_staging_tmp_1/asan-symbolized-linux-release-v8-component-43426.zip",
+ "gs://v8-asan/linux-release/asan-symbolized-linux-release-v8-component-43426.zip"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "gsutil upload",
+ "~followup_annotations": [
+ "@@@STEP_LINK@gsutil.upload@https://storage.cloud.google.com/v8-asan/linux-release/asan-symbolized-linux-release-v8-component-43426.zip@@@"
+ ]
+ },
+ {
+ "cmd": [
+ "python",
+ "-u",
+ "\nimport os\nimport sys\nos.remove(sys.argv[1])\n",
+ "[TMP_BASE]/chrome_staging_tmp_1/asan-symbolized-linux-release-v8-component-43426.zip"
+ ],
+ "cwd": "[SLAVE_BUILD]",
+ "name": "asan-symbolized-linux-release-v8-component-43426.zip",
+ "~followup_annotations": [
+ "@@@STEP_LOG_LINE@python.inline@@@@",
+ "@@@STEP_LOG_LINE@python.inline@import os@@@",
+ "@@@STEP_LOG_LINE@python.inline@import sys@@@",
+ "@@@STEP_LOG_LINE@python.inline@os.remove(sys.argv[1])@@@",
+ "@@@STEP_LOG_END@python.inline@@@"
+ ]
}
]

Powered by Google App Engine
This is Rietveld 408576698